having trouble with logic on beginnr tic tac toe code

Posted 10 October 2012 - 04:21 AM

seems all you have to do to win is complete a coloumn,and that just aint how it supposed to play.
ive experimented a bit but am a little confused, i also had trouble with a cout.cetf (cout.boolalpha) at the beginning so i settled for while loops which close when an int is changed rather than when false or 1 is returned.(i will review that soon because im gonna get the computer to play next)if you can help me think of a more elegant way to determine a complete row to thas would be helpful.

#include <iostream>
#include <string>

using namespace std;

int playloop = 0;
char a,b,c,d,e,f,g,h,i,j;
char x = 'X';
char o = 'O';
string name;
string name2;
void plyr2 ();
void checkboard();
char brdlog [3] [3];
void getbrdstart ();
void getbrd ();
char input;
void plyr1 ();
int gameloop;
int playloop2;

int main ()

{
getbrdstart ();

cout << "TIC TAC TOE BY DEVONREVENGE\n"<<endl;

cout << "player 1 enter your name..."<<endl;
cin >> name;
cout << "player 2 enter your name..."<<endl;
cin >>name2;

while (gameloop < 10)
{
 while (playloop < 10)
 {
 plyr1 ();
 getbrd ();
 checkboard();
 break;
 }
 while (playloop2 < 10)
 {
 plyr2 ();
 getbrd ();
 checkboard();
 break;
 }
}

return 0;
}

void getbrd ()
{
system("CLS");
cout << a << "|" << b << "|" << c<<endl;
cout << "-"<< "+" << "-" << "+"<< "-"<<endl;
cout << d<<"|"<<e<<"|"<< f <<endl;
  cout << "-"<< "+" << "-" << "+"<< "-"<<endl;
cout << g<<"|"<<h<<"|"<< i << endl;

}

void getbrdstart ()
{
cout << "1" << "|" << "2" << "|" << "3"<<endl;
cout << "-"<< "+" << "-" << "+"<< "-"<<endl;
cout << "4"<<"|"<<"5"<<"|"<< "6" <<endl;
  cout << "-"<< "+" << "-" << "+"<< "-"<<endl;
cout << "7"<<"|"<<"8"<<"|"<< "9\n \n" <<endl;
}


void plyr1 ()
{
cout << name << " input number to place your O"<<endl;
cin >> input;
switch (input)
{
case '1':
a=o;
break;
case '2':
b=o;
break;
case '3':
c=o;
break;
case '4':
d=o;
break;
case '5':
e=o;
break;
case '6':
f=o;
break;
case '7':
g=o;
break;
case '8':
h=o;
break;
case '9':
i=o;
break;
}
}

void plyr2 ()
{
cout << name2 << " input number to place your X"<<endl;
cin >> input;
switch (input)
{
case '1':
a=x;
break;
case '2':
b=x;
break;
case '3':
c=x;
break;
case '4':
d=x;
break;
case '5':
e=x;
break;
case '6':
f=x;
break;
case '7':
g=x;
break;
case '8':
h=x;
break;
case '9':
i=x;
break;
}
}

void checkboard()
{
if ((a,d,g) == o|| (a,b,c) == o|| (d,e,f) ==o|| (g,h,i)==o || (a,d,g)==o || (c,f,i)==o || (b,e,h)==o || (a,e,i)==o || (c,e,g)  == o)
{
cout << name << " WINS!!!"<< endl;
playloop = playloop+20;
playloop2 = playloop2+20;
gameloop = gameloop+20;
}
else if ((a,d,g)== x || (a,b,c)==x|| (d,e,f)==x || (g,h,i)==x || (a,d,g)==x || (c,f,i)==x || (b,e,h)==x || (a,e,i)==x || (c,e,g)  == x)
{
  cout << name2 << " WINS!!!"<< endl;
  playloop = playloop+20;
  playloop2 = playloop2+20;
  gameloop = gameloop+20;
}


}

fanks guys