[dok300]

Hi

I'm trying to create a simple calculator in C.

So far this is what I've got.

#include<stdio.h>
#include<stdlib.h>

int main(void)

{

char ch;
int a,b;


printf ("Would you like to add,multiply,
subtract or divide? Press,a,m,s or d for your choice");
ch = getchar();

if ('%c'= a) 
{
printf("enter two numbers to add");
scanf("%d%d",a,B)/>;
add_total = a+b;
printf("The answer is %d",add_total);
}

if('%c'= m) 
{
printf("enter two numbers to multiply");
scanf("%d%d",a,B)/>;
mult_total = a*b;
printf("The answer is %d", mult_total;);
}

if
('%c'= s){
printf("enter two numbers to subtract");
scanf("%d%d",a,B)/>;
sub_total = a-b;
printf("The answer is %d",sub_total);
}

if ('%c'= d) {
printf("enter two numbers to divide");
scanf("%d%d",a,B)/>;
div_total = a/b;
printf("The answer is %d",div_total);

}
else{
printf("Not a valid selection");
}
return (0);

}

I am fully aware that there is probably a much easier one line way of doing all this but i want to learn what is wrong with this code.( Of course this is not to say any alternative solutions are not welcomed!)

Any input appreciated.

[Xupicor]

Lines akin to this one:

if('%c'= m)

What does that even mean? It shouldn't compile, and if it didn't, then you should post complete compile log.

[JackOfAllTrades]

And another that needs to read the manual for scanf.

[raghav.naganathan]

Ideally,for a basic calculator, you might want to use a switch statement.So basically what you may need are 2 variables for the numbers,and of course, the operator.

So you go about this in the following way:

Ask the user to enter 2 numbers.
Ask the user to provide an operator for these 2 numbers and save it in a char variable say op.

switch(op)
{
case '+' : //code for addition and of course, break;
case '-' : //code for subtraction and of course, break;
}

similarly for the other operators like *,/ and %(modulo)

P.S : As my esteemed DIC members have suggested, you need to look into the syntax of scanf()


regards,
Raghav

This post has been edited by raghav.naganathan: 18 November 2012 - 11:43 PM