[TheAKB]

The below code changes the preset location of the "PageUp" and "PageDn" buttons. this code does what i need it to do and swap them around but when it insertsBefore it is not adding any padding and the buttons are joined up. I have tried all the ways i can think of such as style, padding ect and i have tried this on the getElementsByTagName and on the div.

Does anyone know how i can add some padding between PageDown and Page Up?

                       var els = document.getElementsByTagName('*');
                       var PageUp;
                       var PageDown;

                       for (var i = 0, j = els.length; i < j; i++) {
                           var s = els[i].id
                           if (s != '') {
                               if (s.endsWith("Control_PageUp") != -1) {
                                   PageUp = els[i]
                               }
                               if (s.endsWith("Control_PageDown") != -1) {
                                   PageDown = els[i]
                               }

                               if (PageDown != null & !PageUp != null) {
                                   PageDown.parentNode.insertBefore(PageUp, PageDown.nextSibling);
                                   break;
                               }
                           }
                       }
                       String.prototype.endsWith = function(s) {
                           return this.length >= s.length && this.substr(this.length - s.length) == s;
                       }

[Dormilich]

two things
- line #15 is quite weird. you use bitwise AND instead of logical AND and you have a double negation in the second half. additionally, neither variable is null. I’d just go for if (PageDown && !PageUp)

- Padding has nothing to do with JS, it is "merely" a CSS issue (though you can change CSS with JS, it still is a way of working with CSS). if your original CSS doesn’t work anymore, something in the element order must have changed so, that the CSS rules do not match.


PS. document.getElementById() is one of the few DOM getters that can return null.

PPS. unlike many other programming languages, null is not the value of an unset variable, that would be undefined.

PPPS. explicitly comparing to null requires a type-safe comparison: if (null === variable)