[jimblumberg]

I suggest you read the documentation for your IDE and increase the compiler warning levels. Here are some of the error my compiler issues, without any increase in warning levels.

Quote

Equip.h||In member function ‘std::string Equip::getName()’:|
Equip.h|46|warning: statement has no effect [-Wunused-value]|
Equip.h|47|warning: no return statement in function returning non-void [-Wreturn-type]|
Equip.h||In member function ‘Equip Equip::loadEquip(int)’:|
Equip.h|79|error: ‘atoi’ was not declared in this scope|
Item.h||In member function ‘int Item::getId()’:|
Item.h|24|warning: statement has no effect [-Wunused-value]|
Item.h|25|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘std::string Item::getName()’:|
Item.h|27|warning: statement has no effect [-Wunused-value]|
Item.h|28|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘int Item::getHp()’:|
Item.h|30|warning: statement has no effect [-Wunused-value]|
Item.h|31|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘int Item::getMp()’:|
Item.h|33|warning: statement has no effect [-Wunused-value]|
Item.h|34|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘int Item::getQnt()’:|
Item.h|36|warning: statement has no effect [-Wunused-value]|
Item.h|37|warning: no return statement in function returning non-void [-Wreturn-type]|
Misc.h||In member function ‘Misc Misc::loadMisc(int)’:|
Misc.h|43|error: ‘atoi’ was not declared in this scope|
Bag.h||In member function ‘Item Bag::loadItem(int)’:|
Bag.h|176|error: ‘atoi’ was not declared in this scope|
Player.h||In constructor ‘Player::Player()’:|
Player.h|43|warning: comparison between signed and unsigned integer expressions [-Wsign-compare]|
Monster.h||In member function ‘Monster Monster::loadMonster(int)’:|
Monster.h|55|error: ‘atoi’ was not declared in this scope|
Jogo.cpp||In function ‘int getRandom(int, int)’:|
/home/jim/Working/homework/c++/monsters/Jogo.cpp|27|error: ‘GetTickCount’ was not declared in this scope|
/home/jim/Working/homework/c++/monsters/Jogo.cpp|27|error: ‘srand’ was not declared in this scope|
/home/jim/Working/homework/c++/monsters/Jogo.cpp|28|error: ‘rand’ was not declared in this scope|
/home/jim/Working/homework/c++/monsters/Bag.h||In member function ‘Misc Bag::findMisc(int)’:|
/home/jim/Working/homework/c++/monsters/Bag.h|84|warning: control reaches end of non-void function [-Wreturn-type]|
/home/jim/Working/homework/c++/monsters/Bag.h||In member function ‘Item Bag::findItem(int)’:|
/home/jim/Working/homework/c++/monsters/Bag.h|72|warning: control reaches end of non-void function [-Wreturn-type]|
/home/jim/Working/homework/c++/monsters/Bag.h||In member function ‘Equip Bag::findEquip(int)’:|
/home/jim/Working/homework/c++/monsters/Bag.h|55|warning: control reaches end of non-void function [-Wreturn-type]|
||=== Build finished: 7 errors, 16 warnings ===|

You need to fix all of these warnings and errors.

When I have a few more warnings enabled:

Spoiler

Quote

Equip.h||In constructor ‘Equip::Equip()’:|
Equip.h|19|warning: ‘Equip::id’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::max_hp’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::max_mp’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::name’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::forca’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::defesa’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::str’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::intel’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::vit’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::desc’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|19|warning: ‘Equip::equip_slot’ should be initialized in the member initialization list [-Weffc++]|
Equip.h||In constructor ‘Equip::Equip(int, int, int, std::string, int, int, int, int, int, std::string, int)’:|
Equip.h|20|warning: declaration of ‘equip_slot’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘desc’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘vit’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘intel’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘str’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘defesa’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘forca’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘max_mp’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘max_hp’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: declaration of ‘id’ shadows a member of 'this' [-Wshadow]|
Equip.h|20|warning: ‘Equip::id’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::max_hp’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::max_mp’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::name’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::forca’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::defesa’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::str’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::intel’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::vit’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::desc’ should be initialized in the member initialization list [-Weffc++]|
Equip.h|20|warning: ‘Equip::equip_slot’ should be initialized in the member initialization list [-Weffc++]|
Equip.h||In member function ‘std::string Equip::getName()’:|
Equip.h|46|warning: statement has no effect [-Wunused-value]|
Equip.h|47|warning: no return statement in function returning non-void [-Wreturn-type]|
Equip.h||In member function ‘Equip Equip::loadEquip(int)’:|
Equip.h|75|warning: declaration of ‘id’ shadows a member of 'this' [-Wshadow]|
Equip.h|79|error: ‘atoi’ was not declared in this scope|
Item.h||In constructor ‘Item::Item()’:|
Item.h|12|warning: ‘Item::id’ should be initialized in the member initialization list [-Weffc++]|
Item.h|12|warning: ‘Item::name’ should be initialized in the member initialization list [-Weffc++]|
Item.h|12|warning: ‘Item::hp’ should be initialized in the member initialization list [-Weffc++]|
Item.h|12|warning: ‘Item::mp’ should be initialized in the member initialization list [-Weffc++]|
Item.h|12|warning: ‘Item::qnt’ should be initialized in the member initialization list [-Weffc++]|
Item.h||In constructor ‘Item::Item(int, std::string, int, int, int)’:|
Item.h|13|warning: declaration of ‘qnt’ shadows a member of 'this' [-Wshadow]|
Item.h|13|warning: declaration of ‘mp’ shadows a member of 'this' [-Wshadow]|
Item.h|13|warning: declaration of ‘hp’ shadows a member of 'this' [-Wshadow]|
Item.h|13|warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]|
Item.h|13|warning: declaration of ‘id’ shadows a member of 'this' [-Wshadow]|
Item.h|13|warning: ‘Item::id’ should be initialized in the member initialization list [-Weffc++]|
Item.h|13|warning: ‘Item::name’ should be initialized in the member initialization list [-Weffc++]|
Item.h|13|warning: ‘Item::hp’ should be initialized in the member initialization list [-Weffc++]|
Item.h|13|warning: ‘Item::mp’ should be initialized in the member initialization list [-Weffc++]|
Item.h|13|warning: ‘Item::qnt’ should be initialized in the member initialization list [-Weffc++]|
Item.h||In member function ‘int Item::getId()’:|
Item.h|24|warning: statement has no effect [-Wunused-value]|
Item.h|25|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘std::string Item::getName()’:|
Item.h|27|warning: statement has no effect [-Wunused-value]|
Item.h|28|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘int Item::getHp()’:|
Item.h|30|warning: statement has no effect [-Wunused-value]|
Item.h|31|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘int Item::getMp()’:|
Item.h|33|warning: statement has no effect [-Wunused-value]|
Item.h|34|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘int Item::getQnt()’:|
Item.h|36|warning: statement has no effect [-Wunused-value]|
Item.h|37|warning: no return statement in function returning non-void [-Wreturn-type]|
Item.h||In member function ‘void Item::setQnt(int)’:|
Item.h|39|warning: declaration of ‘qnt’ shadows a member of 'this' [-Wshadow]|
Misc.h||In constructor ‘Misc::Misc()’:|
Misc.h|11|warning: ‘Misc::id’ should be initialized in the member initialization list [-Weffc++]|
Misc.h|11|warning: ‘Misc::name’ should be initialized in the member initialization list [-Weffc++]|
Misc.h|11|warning: ‘Misc::qnt’ should be initialized in the member initialization list [-Weffc++]|
Misc.h|11|warning: ‘Misc::value’ should be initialized in the member initialization list [-Weffc++]|
Misc.h||In constructor ‘Misc::Misc(int, std::string, int, int)’:|
Misc.h|12|warning: declaration of ‘qnt’ shadows a member of 'this' [-Wshadow]|
Misc.h|12|warning: declaration of ‘value’ shadows a member of 'this' [-Wshadow]|
Misc.h|12|warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]|
Misc.h|12|warning: declaration of ‘id’ shadows a member of 'this' [-Wshadow]|
Misc.h|12|warning: ‘Misc::id’ should be initialized in the member initialization list [-Weffc++]|
Misc.h|12|warning: ‘Misc::name’ should be initialized in the member initialization list [-Weffc++]|
Misc.h|12|warning: ‘Misc::qnt’ should be initialized in the member initialization list [-Weffc++]|
Misc.h|12|warning: ‘Misc::value’ should be initialized in the member initialization list [-Weffc++]|
Misc.h||In member function ‘void Misc::setQnt(int)’:|
Misc.h|34|warning: declaration of ‘qnt’ shadows a member of 'this' [-Wshadow]|
Misc.h||In member function ‘Misc Misc::loadMisc(int)’:|
Misc.h|38|warning: declaration of ‘id’ shadows a member of 'this' [-Wshadow]|
Misc.h|43|error: ‘atoi’ was not declared in this scope|
Bag.h||In member function ‘Item Bag::loadItem(int)’:|
Bag.h|176|error: ‘atoi’ was not declared in this scope|
Player.h||In constructor ‘Player::Player()’:|
Player.h|28|warning: ‘Player::name’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::nivel’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::hp’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::mp’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::forca’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::defesa’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::max_hp’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::max_mp’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::exp’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::lvlup’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::str’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::intel’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::vit’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::equip_slot’ should be initialized in the member initialization list [-Weffc++]|
Player.h|28|warning: ‘Player::mochila’ should be initialized in the member initialization list [-Weffc++]|
Bag.h||In constructor ‘Bag::Bag()’:|
Bag.h|7|warning: ‘Bag::equip’ should be initialized in the member initialization list [-Weffc++]|
Bag.h|7|warning: ‘Bag::usable’ should be initialized in the member initialization list [-Weffc++]|
Bag.h|7|warning: ‘Bag::etc’ should be initialized in the member initialization list [-Weffc++]|
Bag.h|7|warning: ‘Bag::eqpIter’ should be initialized in the member initialization list [-Weffc++]|
Bag.h|7|warning: ‘Bag::usbIter’ should be initialized in the member initialization list [-Weffc++]|
Bag.h|7|warning: ‘Bag::etcIter’ should be initialized in the member initialization list [-Weffc++]|
Player.h||In constructor ‘Player::Player()’:|
Player.h|28|note: synthesized method ‘Bag::Bag()’ first required here |
Player.h|43|warning: comparison between signed and unsigned integer expressions [-Wsign-compare]|
Player.h||In member function ‘void Player::setName(std::string)’:|
Player.h|211|warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]|
Player.h||In member function ‘void Player::setHp(int)’:|
Player.h|214|warning: declaration of ‘hp’ shadows a member of 'this' [-Wshadow]|
Player.h||In member function ‘void Player::setMp(int)’:|
Player.h|217|warning: declaration of ‘mp’ shadows a member of 'this' [-Wshadow]|
Monster.h||In constructor ‘Monster::Monster()’:|
Monster.h|22|warning: ‘Monster::id’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::name’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::nivel’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::hp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::mp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::forca’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::defesa’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::max_hp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::max_mp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::exp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::str’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::intel’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::vit’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::drops’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|22|warning: ‘Monster::dropIter’ should be initialized in the member initialization list [-Weffc++]|
Monster.h||In constructor ‘Monster::Monster(int, std::string, int, int, int, int, int, int, int, int, int, std::vector<int>)’:|
Monster.h|23|warning: declaration of ‘drops’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘vit’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘intel’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘str’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘exp’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘defesa’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘forca’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘mp’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘hp’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘nivel’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: declaration of ‘id’ shadows a member of 'this' [-Wshadow]|
Monster.h|23|warning: ‘Monster::id’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::name’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::nivel’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::hp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::mp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::forca’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::defesa’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::max_hp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::max_mp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::exp’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::str’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::intel’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::vit’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::drops’ should be initialized in the member initialization list [-Weffc++]|
Monster.h|23|warning: ‘Monster::dropIter’ should be initialized in the member initialization list [-Weffc++]|
Monster.h||In member function ‘Monster Monster::loadMonster(int)’:|
Monster.h|51|warning: declaration of ‘id’ shadows a member of 'this' [-Wshadow]|
Monster.h|55|error: ‘atoi’ was not declared in this scope|
Monster.h||In member function ‘void Monster::setName(std::string)’:|
Monster.h|138|warning: declaration of ‘name’ shadows a member of 'this' [-Wshadow]|
Monster.h||In member function ‘void Monster::setHp(int)’:|
Monster.h|141|warning: declaration of ‘hp’ shadows a member of 'this' [-Wshadow]|
Monster.h||In member function ‘void Monster::setMp(int)’:|
Monster.h|144|warning: declaration of ‘mp’ shadows a member of 'this' [-Wshadow]|
Jogo.cpp||In function ‘int getRandom(int, int)’:|
Jogo.cpp|27|error: ‘GetTickCount’ was not declared in this scope|
Jogo.cpp|27|error: ‘srand’ was not declared in this scope|
Jogo.cpp|28|error: ‘rand’ was not declared in this scope|
Jogo.cpp||In function ‘void criarPersonagem()’:|
Jogo.cpp|33|warning: no previous declaration for ‘void criarPersonagem()’ [-Wmissing-declarations]|
Jogo.cpp||In function ‘void equipMenu()’:|
Jogo.cpp|115|warning: switch missing default case [-Wswitch-default]|
Bag.h||In member function ‘Misc Bag::findMisc(int)’:|
Bag.h|84|warning: control reaches end of non-void function [-Wreturn-type]|
Bag.h||In member function ‘Item Bag::findItem(int)’:|
Bag.h|72|warning: control reaches end of non-void function [-Wreturn-type]|
Bag.h||In member function ‘Equip Bag::findEquip(int)’:|
Bag.h|55|warning: control reaches end of non-void function [-Wreturn-type]|

Quote

||=== Build finished: 8 errors, 152 warnings ===|

As you can see a few more issues.

Jim

[sepp2k]

As I said already:

sepp2k, on 04 January 2013 - 04:16 PM, said:

You should enable (and read) warnings for your code. Your getter methods don't have any return statements (which you definitely will get warnings about if they're enabled), so calling them will invoke undefined behavior, causing the random values you're seeing.

PS: You shouldn't put all your code in your header files.

[lscorpionlmi]

Thanks it's solved, just missed some code.

I thought that warning levels were default, didn't knew i could raise its level.

Really thanks