[AwesomeProgrammer]

Hello, I have recently been trying to make a new program making multidimensional arrays! Here is my code:

 #include <iostream>

using namespace std;

int main()
{

    const int MAX_ROWS = 3;
    const int MAX_COLUMNS = 3;
    
    char table [MAX_ROWS][MAX_COLUMNS] = {
        {  {'O', 'X', 'O'},
            {'O', 'X', 'X'},
            {'X', 'O', 'X'} }
    };
    
    for (int i = 0;i<MAX_ROWS;i++){
        for (int j = 0; j<MAX_COLUMNS;j++) {
            cout << table[i][j];
        }
        cout << endl;
    }
    
    return 0;
}

I get the error: Excess elements in scalar initializer on line 12 on the X.
Could anybody help?

[jimblumberg]

It looks like maybe you have too many braces in your initializer.

Jim

[mojo666]

You have an extra set of brackets.

    char table [MAX_ROWS][MAX_COLUMNS] = {
        {  {'O', 'X', 'O'},
            {'O', 'X', 'X'},
            {'X', 'O', 'X'} }
    };
    //should be 
    char table [MAX_ROWS][MAX_COLUMNS] = {
        {'O', 'X', 'O'},
            {'O', 'X', 'X'},
            {'X', 'O', 'X'}
    };

[AwesomeProgrammer]

Ok thanks that solve that problem, however, this code:

#include <iostream>

using namespace std;

int main()
{

    const int MAX_ROWS = 3;
    const int MAX_COLUMNS = 3;
    
    char table [MAX_ROWS][MAX_COLUMNS] = {
        {  'O', 'X', 'O',
            'O', 'X', 'X',
            'X', 'O', 'X' }
    };
    
    for (int i = 0;i<MAX_ROWS;i++){
        for (int j = 0; j<MAX_COLUMNS;j++) {
            cout << table[i][j];
        }
        cout << endl;
    }
    
    return 0;
}

gets an error message: Excess elements in array initializer on line 13 on the O. Could anybody help again?

Oops sorry i should of deleted that 4th post.

Thanks for quick reply!

Sorry for post 4! I didn't read the posts fully Thanks!

[ipoood]

You don't have enough brackets now.

char table [MAX_ROWS][MAX_COLUMNS] = {  

         {  'O', 'X', 'O',  

             'O', 'X', 'X',  

             'X', 'O', 'X' }  

     }; 

should be like this:

char table[MAX_ROWS][MAX_COLUMNS] = {
{'O', 'X', 'O'},

{'O', 'X', 'X'},  

{'X', 'O', 'X'}

} 

Each row needs to have its own set of brackets with a comma in between each one.

[jjl]

Quote

Each row needs to have its own set of brackets with a comma in between each one.

Not every row needs it's own set of brackets, it is sufficient however. Since a 2D array is continuously addressed in memory, you can omit the row brackets.

char table[MAX_ROWS][MAX_COLUMNS] = {
'O', 'X', 'O',

'O', 'X', 'X',  

'X', 'O', 'X'
} 

[jimblumberg]

Actually if I try to leave out the row braces I get these warnings:

Quote

main.cpp||In function ‘int main()’:|
main.cpp|13|warning: missing braces around initializer for ‘char [3]’ [-Wmissing-braces]|
main.cpp|13|warning: missing braces around initializer for ‘char [3]’ [-Wmissing-braces]|
main.cpp|13|warning: missing braces around initializer for ‘char [3]’ [-Wmissing-braces]|

Jim

[jjl]

Quote

Actually if I try to leave out the row braces I get these warnings:

I do if I compile with -Wall. I also get this warning with statements like

int arr[3][3] = {0};

Statements like this do not go against the standard which states that the left out aggregate shall be initialized implicitly.