[Dormilich]

then you have either different keys (line break???) or your method has a different code.

[Darkranger85]

Not sure what you mean.

[Dormilich]

well, if the index is set (var_dump on session), and your method returns false (var_dump on method), something is very wrong there (you could test var_dump(isset($_SESSION['user_id'])); just for fun).

[Darkranger85]

IT also says boolean false.

I dont understand what could be wrong with such a simple function.

[Darkranger85]

Ok, I might have had a small breakthrough but I'm not sure.

I am now getting an infinite redirect loop.

And I found that it goes away when I comment out the block of code that checks for the user to be active and then logs them out.

So perhaps that block is where the error is and it's destroying the session.

Hmm, after some testing I'm not sure anymore. Cause with that block commented out it seems I can't log out. And var_dumping the session aray on the init script then shows an empty array. . .

I'm really starting to feel overwhelmed.

I'm wondering if there are simply so many things that aren't working right because of my changing from functions to classes that I can't even figure out where the actual issues are coming from.

[Darkranger85]

I'm wondering between two options.

Should I continue debugging this code, or should I completely redo the script again but this time rather than just copying and pasting functions into classes, reworking it one by one.

Or am I jumping the gun with my frustration and giving up on it too soon?

[Dormilich]

at this point I recommend to to completely redo it.

[Darkranger85]

Alright

Progress is going well.

The login system and registration system works as expected.

The issue I'm having now is I have two function scripts, I'm trying to call a function from one in the other and it says that it's an undefined variable.

I have the class set in init.php and yet it's not working.

Here's the function, it's the $Check variable that it has a problem with.

 	public static function protectPage(){
 			
 		if(!$Check->loggedIn()){
 			header('Location: protected.php');
			exit();
		}
	}

Yet on init.php I have

global $Check;

I've double checked spellings and such and everything seems fine.

[andrewsw]

You shouldn't need to use global, but does init.php instantiate $Check?

global should be used within your function:

	public static function protectPage(){
		global $Check;	
		if(!$Check->loggedIn()){
			header('Location: protected.php');
		exit();
	}
}

[Darkranger85]

No, users.php instantiates it.

[Dormilich]

first, forget global. pass variables if you need them.

	public static function protectPage(whatever_intterface_it_is $Check){
		if(!$Check->loggedIn()){
			header('Location: protected.php');
		exit();
	}

second, avoid redirects. you’re inside the script, so you can easily provide the content you want.

though the question remains, why do you have that static method there? it is not related to the class and it uses a foreign object …

[Darkranger85]

Ok, lose the globals, pass the variables. Avoid using the redirect, I'll work on that.

Not so sure what you mean by it not being related. I thought protecting a page was related to security.

As for the foreign object. Are you saying it's bad to use it in the first place?

[Dormilich]

Darkranger85, on 01 March 2013 - 03:30 PM, said:

Not so sure what you mean by it not being related. I thought protecting a page was related to security.

depends what you understand by security. I would group it (access to restricted content) under "content control".

Darkranger85, on 01 March 2013 - 03:30 PM, said:

As for the foreign object. Are you saying it's bad to use it in the first place?

let me put it this way: you have a method that doesn’t interact with the class and the only object used in that method needs to be imported.

[Darkranger85]

Ok, I passed the variables and such and got it working. I also replaced the header redirect.

 	public function protectPage(){
 			
 		if(!$this->Check->loggedIn()){
 			include '/includes/overall/header_main.php';
			echo '<div class="msg_module">';
			echo '<h2>Protected Page:</h2>';
			echo 'The page you are trying to access requires you to login.<br /><br />';
			echo '<a href="index.php">Login</a>';
			echo '</div>';
			include '/includes/overall/footer_main.php';
			exit();
		}
	}	

EDIT: So I should make a separate class for one method? And if I make a content control class, isn't it going to have the same issue? Having to call on the method to check the users session.

This post has been edited by Darkranger85: 01 March 2013 - 09:51 AM

[Dormilich]

at this point I usually recommend templates …

one tip for re-useability of objects: don’t echo inside methods, only return. this way you still have the choice what to do with the content.