[aprilrocks92]

I have been working on the following method for collision detection between a spaceship, its bullets and the asteroids in a 2D game environment. However, I am not getting the proper collision detection effect, as it seems like the collisions are only detected occasionally. Once detected, there is no problem, points increment appropriately.

How can I improve my collision detection to properly function? Thanks!

		public void CheckCollisionRockShip ()
		{
			foreach (Rocks rock in rocks) {
				if(spriteRectangle.Intersects(rock.rockRectangle)){
					rock.isVisible = false;
					Points += 1;
				}
			}
		}
		public void CheckCollisionBulletRock ()
		{
			foreach (Bullets bullet in bullets) {
				foreach(Rocks rock in rocks) {
					if(bullet.bulletRectangle.Intersects(rock.rockRectangle)){
					rock.isVisible = false;
					}
				}
			}
		}

[Skydiver]

There doesn't seem to be enough information. How do you know that a collision should have been detected, but was not correctly detected? Does your Intersects() method take visibility into account or does it just do raw bounds checking?

[aprilrocks92]

Skydiver, on 07 March 2013 - 06:54 AM, said:

There doesn't seem to be enough information. How do you know that a collision should have been detected, but was not correctly detected? Does your Intersects() method take visibility into account or does it just do raw bounds checking?

When I fly the spaceship over a rock, or fire a bullet at a rock, sometimes the rock disappears, and sometimes it does not.

I have the following variables related to the spaceship:

 
shipRectangle = new Rectangle ((int)shipPosition.X, (int)shipPosition.Y, shipTexture.Width, shipTexture.Height);
shipPosition = shipVelocity + shipPosition;
shipOrigin = new Vector2 (shipRectangle.Width / 2, shipRectangle.Height / 2);

rocks

Rectangle rockRectangle = new Rectangle ((int)position.X, (int)position.Y, texture.Width, texture.Height);

bullets

Rectangle bulletRectangle = new Rectangle((int)positionBullet.X, (int)positionBullet.Y, texture.Width, texture.Height);

[pharylon]

Hey, cool, I'm working on a game in C# as well. Are you using XNA?

Anyway, I'm a little confused as to why you have multiple collision checking methods. I'm assuming you have a base "sprite" class, and my feeling is you should just have one collision detection method there.

Here's what I do:

public virtual bool detectCollision(Rectangle otherRectangle)
        {
            return otherRectangle.Intersects(this.collisionRectangle);
        }

Simple, right? Then, in my Update method, I call any appropriate checks (for instance, a for loop through the alien lasers that checks to see if they intersect with the player ship). If it returns true, I fire off the appropriate event. This works really well in general, though I plan to do an override later for less rectangle-y shaped objects that's more accurate.

Doing it this way will also keep you from having to pass the entire rocks and bullets list to the playerShip.

If you want to browse my code, you can see it at github. I want to warn you, it's not really a "game" yet, just the foundation of one, but the collision detection works fine.