[KorvusKoraks]

Okay, so this is a homework assignment. I've been stuck with a pretty annoying problem.

I've cut out non-relevant parts of the code. The type of "id" is const std::string&.

Person Person::add(Person *p)
{
   std::string test = p->getId();
   char id1[11];
   strcpy(id1, test.c_str()); // the crash happens at this point
}

So what am I doing wrong? This works well ("people" is a vector):

char id2[11];
strcpy(id2, people[i].getId().c_str());

[baavgai]

test.c_str() would have to be a length of 10 or less. Larger than that and you go boom. Why would you want to convert to a c-string in the first place?

[KorvusKoraks]

Thanks for the answer, that was the problem (the arrays were too small).

I was having some trouble comparing the strings together and tried to do it "the hard way" as one solution.

[jimblumberg]

Why don't you post your attempt at comparing std::strings? Maybe we can show you what you're doing wrong with the strings, it should be much easier to compare strings.

Jim

[KorvusKoraks]

I actually had forgotten a whole else block from the code... that's why it didn't work. So it had nothing to do with the strings after all.

But thanks for the answers, anyway.