[antukin_cs]

Private Sub cmdok_Click()
Static y As Integer
 Adodc1.Refresh
	With Adodc1.Recordset
	
	If .RecordCount > 0 Then
		 If .EOF = False Then
		.MoveFirst
		If !UserName = txtUsername And !Password = txtPassword Then
		MsgBox "Login Successful!"
		frmMenu.Show
		Unload Me

	Else
		MsgBox "Invalid username/password!", vbOKOnly + vbCritical, "Access denied!"
		txtUsername.Text = ""
		txtPassword.Text = ""
		txtUsername.SetFocus
	End If
	End If
	End If
	End With
End Sub

somebody please help me fix these code.. my username and password are saved on MS Access...the problem is that this code only accepts the 1st username and password stored on Access, if I try to login with the 2nd username and password stored on Access, it displays the msgbox stating "Invalid username/password!"...need immediate help! thanks in advance!

[PsychoCoder]

For starters, you're telling it to move to the first record (reason for this I don't know) when you use the .MoveFirst, all you need to check for is a record count, which you do with If .RecordCount > 0. When you return a recordset the cursor is always at the first record.

Second, in all my years programming (maybe I have used it its just been to long for my old mind to remember lol) Ive never seen !UserName or the ! used with anything involving a RecordSet. Ive made some changes to your code, just to get rid of some stuff I dont really think is necessary.

Now, I'd like to see your query please, the problem may lie there.

Private Sub cmdok_Click()
Static y As Integer
Adodc1.Refresh
	With Adodc1.Recordset
	
	If .RecordCount > 0 Then
		If !UserName = txtUsername And !Password = txtPassword Then
			MsgBox "Login Successful!"
			frmMenu.Show
			Unload Me
		Else
			MsgBox "Invalid username/password!", vbOKOnly + vbCritical, "Access denied!"
			txtUsername.Text = ""
			txtPassword.Text = ""
			txtUsername.SetFocus
		End If
	End With
End Sub

[antukin_cs]

what query?? you mean the username and password saved in MS Access?? i used a table not a query..is that the problem?

i just tested the code you gave me but it didnt worked....same thing happened..

This post has been edited by antukin_cs: 12 October 2007 - 05:18 AM

[PsychoCoder]

You have to have something somewhere to get the data from the database like select something from some table where something = something, you don't have that anywhere?

Also, I never said the modified code would work, I said I modified it to remove some unnecessary code

[antukin_cs]

no i dont have it.. i just learned the code recently and i just cant debug it myself...the thing you said about "select something from some table where something = something", i dont know how to manipulate a table or a query whatever it is...the code is workin fine but it only accepts the first username and password saved..

This post has been edited by antukin_cs: 12 October 2007 - 05:39 AM

[antukin_cs]

hey man! i fixed the damn code! you were ryt, the error comes from the code you removed (.MoveFirst)

the thing is, i thought about what u said about "select something from some table where something = something"

i just removed the .MoveFirst and replaced it with .MoveNext and it worked!

[PsychoCoder]

Try using the ADODC.RecordSet.Find() Function and see if that helps:

Private Sub cmdok_Click()
Static y As Integer
Adodc1.Refresh
	With Adodc1.Recordset
		Dim query As String
		query = "username = '" & txtUsername.Text & "'"
		query = query & " and password = '" & txtpassword.Text & "'"
		.Find (query)
		
		If .RecordCount > 0 Then
			MsgBox "Login Successful!"
			frmMenu.Show
			Unload Me
		Else
			MsgBox "Invalid username/password!", vbOKOnly + vbCritical, "Access denied!"
			txtUsername.Text = ""
			txtpassword.Text = ""
			txtUsername.SetFocus
		End If
	End With
End Sub
End Sub

Replace the fields I used in my query variable with the column names in your database.

Hope that helps

[antukin_cs]

Private Sub cmdok_Click()
Static y As Integer
Adodc1.Refresh
With Adodc1.Recordset
Dim query As String
query = "username = '" & txtUsername.Text & "'"
query = query & " and password = '" & txtpassword.Text & "'"
.Find (query)

If .RecordCount > 0 Then
MsgBox "Login Successful!"
frmMenu.Show
Unload Me
Else
MsgBox "Invalid username/password!", vbOKOnly + vbCritical, "Access denied!"
txtUsername.Text = ""
txtpassword.Text = ""
txtUsername.SetFocus
End If
End With
End Sub
End Sub



hey man. i replaced the bold "query" with Username and Password..but when i logged in..the following error popped up... "Arguements are of the wrong type, are out of acceptable range, or are with conflict with one another" and then when i pressed debug.. the bold and underlined code was highlighted..

This post has been edited by antukin_cs: 12 October 2007 - 06:14 AM

[PsychoCoder]

You're right the Find function requires more arguments than just the 1 I provided. Read the above link and it will show what other arguments are required.

Quote

recordset.Find Criteria, SkipRecords, SearchDirection, Start

[Louisda16th]

I was just wondering. Is criteria just one search condition or can you have more by using AND or something. AND didn't work so I ended up using SQL queries to get the records when I had to do my school project.

[antukin_cs]

well lucky for you Louisda you already know how to use SQL bcoz i dnt...

hey PsychoCoder, i dont have any idea how am i gonna use these "recordset.Find Criteria, SkipRecords, SearchDirection, Start",,il read the link you gave but i dont think il get if its something about SQL...noob hir...

This post has been edited by antukin_cs: 12 October 2007 - 06:31 AM

[PsychoCoder]

I've never used it Louisda16th, but then again Ive never used a drag & drop data control either

[Louisda16th]

Quote

well lucky for you Louisda you already know how to use SQL bcoz i dnt...

Well as far as your project goes. You can learn what you need in a jiffy. Its not all that hard.

PsychoCoder, on 12 Oct, 2007 - 07:01 PM, said:

I've never used it Louisda16th

Im Confused . It refers to Find or SQL statements.

Quote

, but then again Ive never used a drag & drop data control either

You mean ADODC, DAO right?

[antukin_cs]

hey PsychoCoder i didnt get anything there man....i couldnt understand what those codes mean...man i have to study those codes!

[Louisda16th]

Let me help you out. Firstly set your ADODC's recordsource property to 1-adCommandText. Now Try this piece of code.

	Adodc1.RecordSource = "SELECT * FROM USERS WHERE USERNAME ='" + txtUserName.Text + "'"
	Adodc1.Refresh

	If (Adodc1.Recordset.EOF = False) Then
		If (txtPassword.Text = Adodc1.Recordset.Fields("Password")) Then
			MsgBox ("Login Successful")
		Else
			MsgBox ("Login Failure. Incorrect Password")
		End If
	Else
		MsgBox ("Login Failure. Username does not exist.")
	End If

Put this in the Click event of your button. Here's how SQL works. The statement is pretty straightforward. It basically means "Select all records from the table User where the content of the field UserName is equal to the content of the textbox txtUsername". The rest is easy. Also notice the two ' surrounding txtUserName.text. This is because for comparing strings, SQL statements go as

SELECT * FROM Users WHERE UserName = '<your_username>'

* refers to selecting all fields.
Hope this helps .

P.S. I don't know what name you have used for your table. In the SQL statement replace "Users" with your table's name. Just for reference, The general syntax for a simple SQL query statement is:

SELECT <columnlist> FROM <table_name> WHERE <search_condition>

In the columnlist, separate each column name with a comma. Multiple search conditions can be used used AND, OR and I think NOT as well.

Whew! Long time since I used SQL !!

This post has been edited by Louisda16th: 12 October 2007 - 07:27 AM