[kenji]

I know it has to be something really small that I'm missing but for some odd reason i can't find it. The problem with my code is that the WHILE isn't working like is suppose to. It's not counting all 10 entries it just counts 1.

If someone can find where the error is, it would be of great help. Thank you guys in advance.

		private void button1_Click(object sender, EventArgs e)
		{

			int largest = 0;
			int number = 0;
			int counter = 1;
			

			//EXECUTIING BUTTON

			number = int.Parse(txt_Cant.Text);

			
			while (counter < 10)
			{
				
				
				if (number >= largest)
					  {
					largest = number;
					  }
				 else 
					 {
					largest = largest;
					 }


				 lbl_Mejor.Text = largest.ToString();
				 txt_Cant.Focus();
				 txt_Cant.SelectAll();
				 counter = counter + 1;
								
			}
		}

[PsychoCoder]

For this I think I would use a for loop, I would also set the value of the label and textbox outside the loop

for(int i=0; i< 10; i++)
{
     if(number >= largest)
     {
           largest = number;
     }
     else
      }
            largest = largest;
       }
}    

//now set the values of the GUI items
lbl_Mejor.Text = largest.ToString();
txt_Cant.Focus();
txt_Cant.SelectAll();      

[mclang]

For-loop would be my style also.

But otherwise, it would be easier to help if you told us what you are trying to do. Supposedly selecting the largest value from the ones in the TextBox? How is the data laid out in the TextBox - divided with space (4 12 3...), comma (1,15,32...) or how?

[kenji]

It should ask the user 10 times to enter a value, not to enter all the values at once. Psyco I used the code that you provided, but it just gives me 0 for the largest number everytime. It's getting the starting value of the variable.
....I'm a noob sorry.

private void button1_Click(object sender, EventArgs e)
		{
			int largest = 0;
			int number =0;


			for (int i = 0; i < 10; i++)
			{
				if (number > largest)
				{
					largest = number;
				}
				else
				{
					largest = largest;
				}
			} 

		//LARGEST TO TXTBOX
		lbl_Mejor.Text = largest.ToString();
		txt_Cant.Focus();
		txt_Cant.SelectAll();	  
		
		}

[zakary]

you need more code. Where is the input value from the user stored. This code just replaces a number with the larger number if that number is smaller that the Largest number. since you declare and initialize int largest = 0; and int number =0; and never change there value 0 will always be the largest number.

[kenji]

thank you, I will look into it.


Kenji

[kenji]

ya I ate the

number = int.Parse(txt_Cant.Text);

which is the input from the user. :S

[kenji]

I have another question. Right now the loop its working fine, but I can only enter 1 number. It's there a way that I can pause it and let the user enter another value. I know I'm asking kind of like the same question again, but it's eating my brain .

		private void button1_Click(object sender, EventArgs e)
		{

			
			int largest = 0;
			int number = int.Parse(txt_Cant.Text);
						
						
				for (int i = 0; i < 10; i++)
			
			{
				if (number > largest)
				{
					largest = number;
				}
				else
				{
					largest = largest;
				}
				txt_Cant.Focus(); txt_Cant.SelectAll();
				//MessageBox.Show("Ingrese el siguiente");
			
			} 

		//LARGEST TO TXTBOX
		lbl_Mejor.Text = largest.ToString();
		txt_Cant.Focus();txt_Cant.SelectAll();	  
		
		}

[zakary]

No. you can pause a loop, but you can't enter the loop again without starting over. What you can do in create more text boxes and handle 2nd and 3rd values that way.

[kenji]

i thought I could do all from the same textbox. Thank you Zak

[mclang]

Well you can do the whole thing with single TextBox, but it gets tricky. You have to save the previous numbers somewhere while asking more values until the tenth is read. After that you can loop those numbers and find the largest the same way you have already done.

I don't know if this helps at all, but I hope so.

[kenji]

So, it would be like for example saving the info into a .txt and then reading the info from it?

[mclang]

You don't need to save entered values in any textfile - a simple class variable will do.
Something like this:

public class MainForm {
	private List<int> numbers = new List<int>(10);
	...
	private void btnAddNum_Click(object sender, EventArgs e)
	{
		numbers.Add( int.Parse(txt_Cant.Text) );
		if (numbers.Length == 10) {
			// Do the largest comparison, clear list, etc
		}
	}
}