[Mangore]

I use this code that I got it from web is to allowed to write in textbox only numbers but it show me a problem as it show in the pic. I'm using vb2005

 If Asc(e.KeyChar) <> 13 AndAlso Asc(e.KeyChar) <> 8 _
	   AndAlso Not IsNumeric(e.KeyChar) Then
			MessageBox.Show("Only Numbers")
			e.Handled = True
		End If

Attached image(s)

• 

This post has been edited by Mangore: 15 October 2008 - 05:02 PM

[jacobjordan]

You were supposed to put that code in a KeyDown event, not a TextChanged Event. Create a KeyDown event for your text box, and put that same code in it. Like this:

Private Sub TextBox1_KeyDown(ByVal sender As Object, ByVal e As System.Windows.Forms.KeyEventArgs) Handles TextBox1.KeyDown
    If Asc(e.KeyChar) <> 13 AndAlso Asc(e.KeyChar) <> 8 _
       AndAlso Not IsNumeric(e.KeyChar) Then
            MessageBox.Show("Only Numbers")
            e.Handled = True
    End If
End Sub

[Jayman]

It will also work in the KeyPress event. You can find an example here.

[Mangore]

jacobjordan, on 15 Oct, 2008 - 05:10 PM, said:

You were supposed to put that code in a KeyDown event, not a TextChanged Event. Create a KeyDown event for your text box, and put that same code in it. Like this:

Private Sub TextBox1_KeyDown(ByVal sender As Object, ByVal e As System.Windows.Forms.KeyEventArgs) Handles TextBox1.KeyDown
    If Asc(e.KeyChar) <> 13 AndAlso Asc(e.KeyChar) <> 8 _
       AndAlso Not IsNumeric(e.KeyChar) Then
            MessageBox.Show("Only Numbers")
            e.Handled = True
    End If
End Sub

Same problem.

Attached image(s)

• 

[Mangore]

Mangore, on 15 Oct, 2008 - 06:03 PM, said:

jacobjordan, on 15 Oct, 2008 - 05:10 PM, said:

You were supposed to put that code in a KeyDown event, not a TextChanged Event. Create a KeyDown event for your text box, and put that same code in it. Like this:

Private Sub TextBox1_KeyDown(ByVal sender As Object, ByVal e As System.Windows.Forms.KeyEventArgs) Handles TextBox1.KeyDown
    If Asc(e.KeyChar) <> 13 AndAlso Asc(e.KeyChar) <> 8 _
       AndAlso Not IsNumeric(e.KeyChar) Then
            MessageBox.Show("Only Numbers")
            e.Handled = True
    End If
End Sub

Same problem.

It succeed with me in Keypress

Private Sub TextBox1_KeyPress(ByVal sender As Object, ByVal e As System.Windows.Forms.KeyPressEventArgs) Handles TextBox1.KeyPress
        If Asc(e.KeyChar) <> 13 AndAlso Asc(e.KeyChar) <> 8 _
        AndAlso Not IsNumeric(e.KeyChar) Then
            MessageBox.Show("Only Numbers")
            e.Handled = True
        End If

May some one eaxplain it

[jacobjordan]

I screwed up. It will not work in KeyDown, as the KeyDown event has a different signature than the KeyPress event. In other words, the event args for the KeyPress event is different than that for the KeyDown event. However, in the KeyPress event, i do not believe there is any way to supress the key press, like you can do in the KeyDown event with the e.SupressKeyPress property.

This post has been edited by jacobjordan: 15 October 2008 - 07:04 PM

[Mangore]

What does mean "e" and "KeyChar" and Asc(e.KeyChar) <> 13 AndAlso Asc(e.KeyChar) <> 8

[jacobjordan]

'e' is a parameter passed to the KeyPress function. It contains information about the keypress. The "KeyChar" property returns a char of the key that was pressed, so if you pressed the a key, it would return 'a'. The Asc() function is a function that will take a char, and return that char's ASCII code. The "Asc(e.KeyChar) <> 13" checks to make sure the char entered was not a Carriage return, which i really don't see why it would need that. The "Asc(e.KeyChar) <> 8" is checking to see that the backspace key was not pressed, as that is obviously not numeric, but accepted. The IsNumeric() function simply sees if the char you passed it is in a valid numeric format. Put that all together in the form of Asc(e.KeyChar) <> 13 AndAlso Asc(e.KeyChar) <> 8 AndAlso Not IsNumeric(e.KeyChar), and that will evaluate to true if the e.KeyChar is not numeric, was not a carriage return, and not a backspace, thus is is not an accepted key.

[PsychoCoder]

If you look at the signature of your method it has ByVal e As EventArgs when it should be ByVal e As KeyEventArgs. KeyChar is a member of KeyEventArgs, not EventArgs

[jacobjordan]

PsychoCoder, on 15 Oct, 2008 - 10:37 PM, said:

If you look at the signature of your method it has ByVal e As EventArgs when it should be ByVal e As KeyEventArgs. KeyChar is a member of KeyEventArgs, not EventArgs

Actually Psycho, your wrong. KeyChar is a member of KeyPressEventArgs, not KeyEventArgs. I made the same mistake in my first post.

[Mangore]

Thank you all for help!. It is a good infromation for me

[PsychoCoder]

You are right, it's KeyCode that's with KeyEventArgs, which is what I normally use

[dbasnett]

IMHO - I hate that a message box pops up while I am trying to input information.

	'list of valid characters allowed in textbox
	'note if checking numbers, and the number is integer remove "."
	'if checking numbers, and the number has decimals then further checking is required
	Dim validCH() As Char = New Char() {"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", ".", Convert.ToChar(vbCr)}
	Private Sub TextBoxNumOnly_KeyPress(ByVal sender As Object, ByVal e As System.Windows.Forms.KeyPressEventArgs) Handles TextBoxNumOnly.KeyPress
		Debug.WriteLine(Convert.ToByte(e.KeyChar))
		If Array.IndexOf(validCH, e.KeyChar) <> -1 Then
			'character was good code here
			Exit Sub
		End If
		'character was bad code here
		e.Handled = True
	End Sub

[AdamSpeight2008]

I think you need something like this, suppress everything except those allowed and in the correct format.

 Private Sub InputBox_KeyDown(ByVal sender As Object, ByVal e As System.Windows.Forms.KeyEventArgs) Handles InputBox.KeyDown
Select Case e.KeyCode
 Case Keys.D0, Keys.D1, Keys.D2, Keys.D3, Keys.D4, Keys.D5, Keys.D6, Keys.D7, Keys.D8, Keys.D9
   e.SuppressKeyPress = False

 Case Keys.Decimal, Keys.OemPeriod
  If Me.InputBox.Text.Contains(".") Then e.SuppressKeyPress = True
Case Keys.Subtract, Keys.OemMinus
If Me.InputBox.Text.StartsWith("-") Then e.SuppressKeyPress = True
 Case Keys.Delete, Keys.Back, Keys.Enter, Keys.Return
  e.SuppressKeyPress = False
 Case Else
 e.SuppressKeyPress = True
 End Select
 End Sub