[sjlsam]

the function checks a folder that has dinner1.jpg, dinner11.jpg and dinner12.jpg in it, and sending the function dinner1.jpg means it checks to see if that file exists, and tries to increment it until a filename is available for use

the function works as evident by the <cfoutput>'s remarked with DEBUG

my script always errors out saying that "Variable NEWFILENAME is undefined."
its as if the cfreturn is not returning anything

anyone have an idea as to what's wrong?

<!--- folder contains dinner1.jpg, dinner11.jpg, and dinner12.jpg --->
<cfparam name="filepath" default="D:\uploadtest\">

<cffunction name="AutoIncrement" access="public" returntype="string">

	<cfargument name="filename" type="string" required="yes" default=0>
	<cfargument name="path" type="string" required="yes" default=0>
	<cfargument name="step" type="numeric" required="no" default=1>

	<!--- Split filename into name and extension --->
	<cfset extension = listGetAt(filename, 2, '.')>
	<cfset fileroot = listGetAt(filename, 1, '.')>

	<!--- Conduct FileExists for fileroot + step, else increment by 1 and try again --->
	<cfif FileExists("#path#/#fileroot##step#.#extension#")>
		
		<!--- DEBUG ---> <cfoutput>#fileroot##step#.#extension# exists</cfoutput><br />
		
		<cfset AutoIncrement(filename=filename,path=path,step=step+1)>
		
	<cfelse>
		
		<!--- DEBUG ---> <cfoutput>#fileroot##step#.#extension# does not exist</cfoutput>
		
		<!--- filename is valid, return to the user --->
		<cfset filenametest = fileroot & step & "." & extension>
		<cfreturn filenametest>
		
	</cfif>

</cffunction>

<cfset newFileName = AutoIncrement(filename="dinner1.jpg",path=filepath)>
<br /><cfoutput>#newFileName#</cfoutput>

This post has been edited by sjlsam: 29 October 2008 - 01:22 PM

[sjlsam]

someone suggested i do the same functionality with a cfloop and it worked fine that way

sjlsam, on 29 Oct, 2008 - 01:20 PM, said:

the function checks a folder that has dinner1.jpg, dinner11.jpg and dinner12.jpg in it, and sending the function dinner1.jpg means it checks to see if that file exists, and tries to increment it until a filename is available for use

the function works as evident by the <cfoutput>'s remarked with DEBUG

my script always errors out saying that "Variable NEWFILENAME is undefined."
its as if the cfreturn is not returning anything

anyone have an idea as to what's wrong?

<!--- folder contains dinner1.jpg, dinner11.jpg, and dinner12.jpg --->
<cfparam name="filepath" default="D:\uploadtest\">

<cffunction name="AutoIncrement" access="public" returntype="string">

	<cfargument name="filename" type="string" required="yes" default=0>
	<cfargument name="path" type="string" required="yes" default=0>
	<cfargument name="step" type="numeric" required="no" default=1>

	<!--- Split filename into name and extension --->
	<cfset extension = listGetAt(filename, 2, '.')>
	<cfset fileroot = listGetAt(filename, 1, '.')>

	<!--- Conduct FileExists for fileroot + step, else increment by 1 and try again --->
	<cfif FileExists("#path#/#fileroot##step#.#extension#")>
		
		<!--- DEBUG ---> <cfoutput>#fileroot##step#.#extension# exists</cfoutput><br />
		
		<cfset AutoIncrement(filename=filename,path=path,step=step+1)>
		
	<cfelse>
		
		<!--- DEBUG ---> <cfoutput>#fileroot##step#.#extension# does not exist</cfoutput>
		
		<!--- filename is valid, return to the user --->
		<cfset filenametest = fileroot & step & "." & extension>
		<cfreturn filenametest>
		
	</cfif>

</cffunction>

<cfset newFileName = AutoIncrement(filename="dinner1.jpg",path=filepath)>
<br /><cfoutput>#newFileName#</cfoutput>

[garyrgilbert]

I know you probably already figured this out but the problem is that you have the cfreturn inside your cfif statement

<cfif checkSomethign eq true>
do something
<cflese>
do somethign else

<cfreturn>
</cfif>

what happens if it never gets to the cfelse?

It won't return and you will get an error.

At the top of your function set the variable

...function...

<cfset var filenametest =''>

... your if statement code here...

<cfreturn filnametest/>
</cffunction>

[ComboAlex]

garyrgilbert, on 5 Dec, 2008 - 08:27 AM, said:

what happens if it never gets to the cfelse?

It won't return and you will get an error.

At the top of your function set the variable

[code]

It wasn't working because the <cfreturn> tag was inside the <cfif> statement?! I had the same problem and I suspected that it was because the <cfreturn> was placed in the <cfif> statement. However this is very strange if you are perhaps a C or Java or... programmer, because you can place the return statement anywhere in the code... well if the compiler gets to the return statement (for instance if you put an IF statement etc).

Here is my topic. Read also the comments in the code I posted.

[ComboAlex]

Oh, and BTW... in my code (check the link to my other topic) I tested if I get to the inside of the <cfif> statement which I (the compiler) was. So I didn't see any reason that a <cfreturn> wouldn't work in there (in the <cfif> statement). This is why I am very surprised that I have to put the <cfreturn> statement at the end of the function. Odd, very odd.

[ComboAlex]

Check out this topic here. Maybe you will find your answer there.