[Andora]

Quote

Parse error: syntax error, unexpected ';' in C:\wamp\www\index.php on line 32

line 32 is this:

if(move_uploaded_file($_FILES['upload1']['tmp_name'],'../uploads/'.basename($_FILES['upload1']['name']))){$uploads.='<a href="http://localhost/uploads/'.basename($_FILES['upload1']['name'].'" class="upload" target="_blank">'.basename($_FILES['upload1']['name'].'</a>';}

Please help!

P.S. I'm not aiming for security here, I just need help killing the error.

This post has been edited by Andora: 20 November 2008 - 09:11 PM

[no2pencil]

Open : if(move_uploaded_file
Open : ($_FILES['upload1']['tmp_name'],'../uploads/'.basename
Open : ($_FILES['upload1']['name']
Close : )
Close : )
Close : ){$uploads.='<a href="http://localhost/uploads/'.basename
Open : ($_FILES['upload1']['name'].'" class="upload" target="_blank">'.basename
Open : ($_FILES['upload1']['name'].'</a>';}

You've got some parenthesis to close before you can end that statement. Unexpected semi-colon

[Andora]

Woot!

And now I have a non-working file uploader! Any ideas on how I might fix it?

Clarification: The error is gone, but it still isn't working.

This post has been edited by Andora: 20 November 2008 - 08:45 PM

[no2pencil]

Here is a PHP Tutorial that I have used before.

[Moonbat]

I know this isn't related to your question, but I'd seriously suggest breaking up your statement into multiple lines and indenting lines inside of the blocks. It'll make it much more easier for you to debug.

To be honest, I didn't even bother reading your code after seeing it all on one line scrunched up together like that.

[no2pencil]

Hrm, hard to read code winds up with problems, go figure

[Andora]

This is just such a reliable code for me! I don't understand it.

And it shouldn't be that hard to read... The part having issues is here:

if(move_uploaded_file($_FILES['uploada']['tmp_name'],basename($_FILES['uploada']['name'])))

here is a previous version that has worked very well for me. I don't see the difference.

if(move_uploaded_file($_FILES['upload']['tmp_name'],$_POST['path'].basename($_FILES['upload']['name'])))

EDIT: oh, wait. Is it necessary to use enctype="multipart/form-data" in the form?
REDIT: un-be-lievable! Such a trivial error! So costly!

It appears to be resolved, thanks so much to everybody that helped. And to all those ragging on my one-line coding style: you are completely right, I just like to skimp on line breaks on well-proven codes, it makes it easier to read the code as a whole. It usually works.

This post has been edited by Andora: 20 November 2008 - 09:11 PM

[Valek]

Makes it harder to debug though, if there are issues, as PHP does error reporting by line number. If it's all on one line, it'll give you the error on the one line you have, and make it a real pain.

[Andora]

Valek, on 20 Nov, 2008 - 11:56 PM, said:

Makes it harder to debug though, if there are issues, as PHP does error reporting by line number. If it's all on one line, it'll give you the error on the one line you have, and make it a real pain.

I never disputed this. It's just that when you have hundreds of lines of code it is difficult to debug the overall picture, so I condense portions of it into single lines: the upload line, the validation line, the post line, etc... (only when I know that they work).

But I think we are both just repeating the same argument to each other. You have your opinion and I have mine. I'm going to go ahead and use mine. Please get off my back.

This post has been edited by Andora: 23 November 2008 - 12:33 AM

[Valek]

I just made one post, and was not at all being aggressive about it. Personally, I don't care how you do it, it's your script. I was just making a suggestion you can take or leave, nothing more. That's really all this forum is here for, anyway.