[mbarc44]

hello, i'm working on 5x5 slide puzzle game and i'm having trouble displaying each image on each jbutton.

EDIT

ImageIcon images [] = {
					  new ImageIcon("Pictures/Img.0.0.JPG"),
					  new ImageIcon("Pictures/Img.0.1.JPG"),
					  new ImageIcon("Pictures/Img.0.2.JPG"),
					  new ImageIcon("Pictures/Img.0.3.JPG"),
					  new ImageIcon("Pictures/Img.0.4.JPG"),
					  .
					  .
					  new ImageIcon("Pictures/Img.4.4.JPG")};										  


for (int r = 0; r<5; r++){
			for (int c=0; c<5; c++){
				   JButton pic = new JButton(images[0]);
				   pic.addActionListener (this);			
				   one[r][c] = pic;			
				   t.add(pic);}

with this code only one image displays on every button.

This post has been edited by mbarc44: 01 December 2008 - 09:55 AM

[pbl]

mbarc44, on 30 Nov, 2008 - 06:32 PM, said:

hello, i'm working on 5x5 slide puzzle game and i'm having trouble displaying each image on each jbutton.so far i have created a grid and added the buttons(2d array of jbuttons).

ImageIcon images [] = {
					  new ImageIcon("Pictures/Img.0.0.JPG"),
					  new ImageIcon("Pictures/Img.0.1.JPG"),
					  new ImageIcon("Pictures/Img.0.2.JPG"),
					  new ImageIcon("Pictures/Img.0.3.JPG"),
					  new ImageIcon("Pictures/Img.0.4.JPG"),
					  .
					  .
					  new ImageIcon("Pictures/Img.4.4.JPG")};										  

 for (int r = 0; r<5; r++){
			for (int c=0; c<5; c++){ 
				   JButton pic = new JButton(images[0]);
				   pic.addActionListener (this);			
				   one[r][c] = pic;			
				   t.add(pic);} 

with this code only one image displays on every button.
any help would be appreciated.

you have a pic.setIcon(.....) missing

[mbarc44]

I have tried pic.setIcon(.....) before and it didn't work.Every button had the same image like now.

Thank you for your reply.

This post has been edited by mbarc44: 30 November 2008 - 08:30 PM

[pbl]

mbarc44, on 30 Nov, 2008 - 07:29 PM, said:

I have tried pic.setIcon(.....) before and it didn't work.Every button had the same image like now.

so yur code is wrong somewhere... post it

[KYA]

unless I'm mistaken the problem is here:

JButton pic = new JButton(images[0]);

You create the same picture each time. Always index 0 it looks like.

This post has been edited by KYA: 30 November 2008 - 09:02 PM

[mbarc44]

KYA, on 30 Nov, 2008 - 08:02 PM, said:

unless I'm mistaken the problem is here:

JButton pic = new JButton(images[0]);

You create the same picture each time. Always index 0 it looks like.

Yeah thats my problem.I'm kinda having hard time figuring out how to change that.

[KYA]

Use 'r' or 'c' to change it per row or column.

[mbarc44]

I also tried that before.Its slight improvement.Only five images appeared.

Thanks.

This post has been edited by mbarc44: 01 December 2008 - 09:10 AM

[KYA]

Out of how many? Let's say we need the same picture for each row [the inverse applies equally well for columns]

We then use the value of 'r' to pick the index of the picture. That way it will not change until the outer for loop goes again.

[cfoley]

The easiest way round the problem is to store the images in a 5x5 array just like your buttons. Then use images[r][c] to retrieve the picture.

If you want to keep it as a 1D array then use images[(r*colCount)+c]. (where colCount is the number of columns - 5 in this case)

The first option is better because it'll make the program more readable and there's less chance of you (or me) getting the maths wrong.

[mbarc44]

Thank you very much cfoley.Second option worked.I dont know how i didnt try that.Its so simple.

And thanks KYA.

[cfoley]

I guess I got my maths right then.

Glad it's sorted.

[KYA]

Maths ftw!

[mbarc44]

I have hit another bump. Cant really figure out how to swap each image.
Basicially my program is somewhat supposed to look like this one(only with jbuttons and no animation).


Any ideas would be greatly appreciated.

This post has been edited by mbarc44: 02 December 2008 - 12:45 PM

[KYA]

//some sort of loop to do this
tempImage = imageArr[i];
imageArr[i] = imageYouWantToAssign;
imageYouWantToAssign = tempImage;

??