[UG Cyber]

I am trying to make a simple server to print text that is received so i can recall and debug other clients.....The problem is that i keep getting unreadable ASCII characters repeatedly. So i put a filter on so it wont display the text if the first letter of the last received text matches the current. I created a GUI client to send "Hello" to the correct port and IP but nothing is received.
here is the code for the server

//---------------------------------------------------------------------------

#include <vcl.h>
#include <winsock2.h>
#include <iostream>
#pragma hdrstop
using namespace std;

char last;
//---------------------------------------------------------------------------

#pragma argsused
int main(int argc, char* argv[])
{
        WSADATA wsa;
        SOCKET sock;
        SOCKADDR_IN ServerInfo;
        int port;
        //----------------------
        cout << "Console Server -> UG Cyber" << endl;
        cout << "Press F1 to stop server" << endl << endl;
        cout << "Port Desired:  ";
        cin >> port;
        cout << endl;
        //----------------------
        WSAStartup(0x0202, &wsa);
        ServerInfo.sin_family = AF_INET;
        ServerInfo.sin_port = htons(port);
        ServerInfo.sin_addr.s_addr = inet_addr("0.0.0.0");
        sock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
        if (bind(sock, (SOCKADDR*)&ServerInfo, sizeof(ServerInfo)) == INVALID_SOCKET)
        {
                cout << "Could not bind to port " << port << endl;
                return 1;
        }
        listen(sock, 10);
        accept(sock, NULL, NULL);
        while (GetAsyncKeyState(VK_F1) != true)
        {
                char Buffer[1024];
                recv(sock, Buffer, 1024, 0);
                if (Buffer[0] != last)
                {
                        cout << "Client-> " << Buffer << endl;
                        Buffer[0] = last;
                }
        }
        return 0;
}

and here is the console client i also created...

//---------------------------------------------------------------------------

#include <vcl.h>
#include <winsock2.h>
#include <iostream>
#pragma hdrstop
using namespace std;

//---------------------------------------------------------------------------

#pragma argsused
int main(int argc, char* argv[])
{
        WSADATA wsa;
        SOCKET sock;
        SOCKADDR_IN Host;
        char IPAddress[1024];
        int Port;
        //-----------------
        cout << "Console TCP client -> UG Cyber" << endl << endl;
        cout << "IP:  ";
        cin >> IPAddress;
        cout << endl << "Port:  ";
        cin >> Port;
        cout << endl;
        //-----------------
        WSAStartup(0x0202, &wsa);
        Host.sin_family = AF_INET;
        Host.sin_port = htons(Port);
        Host.sin_addr.s_addr = inet_addr(IPAddress);
        sock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
        if (sock == INVALID_SOCKET)
        {
                cout << "Socket Invalid" << endl;
                return 1;
        }
        if (connect(sock, (SOCKADDR*)&Host, sizeof(Host)) == SOCKET_ERROR)
        {
                cout << "Could not connect to " << IPAddress << endl;
                return 1;
        }
        while (true)
        {
                char Message[1024];
                cout << "Send:  ";
                cin >> Message;
                cout << endl;
                //----------------
                if (send(sock, Message, sizeof(Message), 0) == SOCKET_ERROR)
                {
                        cout << "Fatal error: Could not send message" << endl;
                        cout << "Disconnecting....." << endl;
                        break;
                }
        }
        return 1;

}

I am not getting any errors and it does connect....but wont send/receive anything readable.

[UG Cyber]

bump

[JackOfAllTrades]

First thought is always a firewall issue.

You sort of contradict yourself with these two statements:

Quote

nothing is received.

and

Quote

wont send/receive anything readable

Is anything received by the server?

Now, to the code.

while (GetAsyncKeyState(VK_F1) != true)
{
    char Buffer[1024];
    recv(sock, Buffer, 1024, 0);
    if (Buffer[0] != last)
    {
        cout << "Client-> " << Buffer << endl;
        Buffer[0] = last;
    }
}

recv returns a return code. You should be using it.

while (GetAsyncKeyState(VK_F1) != true)
{
    int bytes_received = 0;
    char Buffer[1024];
    bytes_received = recv(sock, Buffer, 1024, 0);
    if (bytes_received == 0)
    {
         // Client disconnected
         break;
     }
     else if (bytes_received == -1)
     {
          // Error
          break;
     }
     // Null-terminate the received data
     Buffer[bytes_received] = 0;
     cout << "Client-> " << Buffer << endl;
}

[UG Cyber]

I did that and i am receiving a -1.
So i placed "WSAGetLastError()" and i am receiving "10057". What does that stand for?
[edit]
Found on google that it stands for "Socket is not connected". However the client and server react when client tries to connect. What could be going wrong??
[edit2] I turned off my firewall to make sure if that was it or not....and it wasnt. its back on now =)

This post has been edited by UG Cyber: 07 December 2008 - 01:44 PM

[homemade-jam]

I've only had a brief look at this but iirc you need a listen socket and a client socket and I think you only have one socket on the server?
http://msdn.microsof...593(VS.85).aspx

[JackOfAllTrades]

Ah yes, h-j's nailed it. accept returns the socket with which you communicate with the client. See the almighty Beej.

[UG Cyber]

Thank you soo much...I love the feeling of the *click of understanding*. But now that raised another question. A While back i created a chat program that worked well, the coding was poor, but it worked.

Here is the link.
http://www.dreaminco...wtopic58831.htm

Now why would that code work but not this one? (That is the code that i used while trying to get this one to work)

[JackOfAllTrades]

You need to link in the Winsock library. See entry 2.4 here. Or here