[tshauck]

I am creating a program to help my friends and I remember when to drink during the game power hour. However I am running into a problem when running the timer. Here is the code

 Public Class Form2
	Private Sub Timer1_Tick(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Timer1.Tick
		Label1.Text = Label1.Text - 1
		If Label1.Text = 0 Then
			Timer1.Stop()
			My.Computer.Audio.Play(My.Resources.applause_wav, AudioPlayMode.Background)
			Form3.Show()
			Me.Close()
		End If
	End Sub

	Private Sub Timer2_Tick(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Timer2.Tick
		Label2.Text = Label2.Text - 1
		If Label2.Text = 0 Then
			My.Computer.Audio.Play(My.Resources.zap1, AudioPlayMode.Background)
			Label2.Text = 60
		End If




	End Sub




	Private Sub CheckBox1_CheckedChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles CheckBox1.CheckedChanged, Timer1.Tick, Timer2.Tick
		'Toggles Pause?/Unpause? and Timer.start/.stop
		If CheckBox1.Checked Then
			Timer1.Enabled = False
			Timer2.Enabled = False
			CheckBox1.Text = "Unpause?"
		Else
			Timer1.Enabled = True
			Timer2.Enabled = True
			CheckBox1.Text = "Pause?"
		End If

	End Sub

	Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
		Form1.Show()
		Timer1.Enabled = False
		Timer2.Enabled = False
		Label2.Text = 60

	End Sub

	Private Sub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click
		Me.Close()

	End Sub
End Class

Any help would be greatly appreciated.

[PsychoCoder]

This is VB.NET code so I'm moving this to the VB.NET forum

[Core]

What line of code is generating the error?

[AdamSpeight2008]

The problem is caused by the original poster treating the value of the Label text as a number, when in truth the are strings.

[Core]

That shouldn't be a problem because VB.NET supports implicit type conversion, so it should automatically convert string to double and double to string.

[dbasnett]

writing code based on implicit conversions is a recipe for disaster.

Option Strict On should either be the default for projects or the first line of code.

[nofear217]

Quote

writing code based on implicit conversions is a recipe for disaster.

agreed....he should at least check to make sure that there is a value within the text field and that it IsNumeric, otherwise, a much safer route would be to use a TryParse to ensure that everything is converted properly if it is able to be done.

[Core]

dbasnett, on 5 Jan, 2009 - 08:26 AM, said:

writing code based on implicit conversions is a recipe for disaster.

Option Strict On should either be the default for projects or the first line of code.

In practice, yes, you should rely on implicit conversion as less as possible. However, for the specified piece of code it should not generate any errors (of course, if Option Strict is disabled).