[du_jleon]

I had a very bad VB teacher and now I am taking another course but I feel short changed because I did not get the basics down, though I passed the class.
I can’t remember how to do what is being suggested to me “It is best that if your method is not returning any data its best to declare your function/method as void in this case in VB. as Sub.”
Now my Try Catch is coming up with an error "Warning 2 Function 'SaveUserActivity' doesn't return a value on all code paths. A null reference exception could occur at run time when the result is used."

 
' This function saves the SavePersonnel
	Public Shared Function SavePersonnel(ByVal Database As String, ByVal FirstName As String, ByVal LastName As String, ByVal PayRate As Integer, ByVal StartDate As DateTime, ByVal EndDate As DateTime)
		Try
			' Add your comments here
			Dim conn As New OleDbConnection("PROVIDER=Microsoft.Jet.OLEDB.4.0;" & _
			"Data Source=" & Database & "")
			conn.Open()
			Dim command As OleDbCommand = conn.CreateCommand()
			Dim strSQL As String
			' Add your comments here
			strSQL = "Insert into tblPersonnel (FirstName, LastName, PayRate, StartDate, EndDate) values ('" & _
					FirstName & "', '" & LastName & "', " & PayRate & ", '" & StartDate & "', '" & EndDate & "')"
			' Add your comments here
			command.CommandType = CommandType.Text
			command.CommandText = strSQL
			' Add your comments here
			command.ExecuteNonQuery()
			' Add your comments here
			conn.Close()
			SavePersonnel = True
		Catch ex As Exception
			SavePersonnel = False
		End Try
		‘Saying to add void here, but I am confused’
	End Function

Thanks,
du_jleon

[du_jleon]

I had a very bad VB teacher and now I am taking another course but I feel short changed because I did not get the basics down, though I passed the class.
I can’t remember how to do what is being suggested to me “It is best that if your method is not returning any data its best to declare your function/method as void in this case in VB. as Sub.”
Now my Try Catch is coming up with an error "Warning 2 Function 'SaveUserActivity' doesn't return a value on all code paths. A null reference exception could occur at run time when the result is used."

 
' This function saves the SavePersonnel
	Public Shared Function SavePersonnel(ByVal Database As String, ByVal FirstName As String, ByVal LastName As String, ByVal PayRate As Integer, ByVal StartDate As DateTime, ByVal EndDate As DateTime)
		Try
			' Add your comments here
			Dim conn As New OleDbConnection("PROVIDER=Microsoft.Jet.OLEDB.4.0;" & _
			"Data Source=" & Database & "")
			conn.Open()
			Dim command As OleDbCommand = conn.CreateCommand()
			Dim strSQL As String
			' Add your comments here
			strSQL = "Insert into tblPersonnel (FirstName, LastName, PayRate, StartDate, EndDate) values ('" & _
					FirstName & "', '" & LastName & "', " & PayRate & ", '" & StartDate & "', '" & EndDate & "')"
			' Add your comments here
			command.CommandType = CommandType.Text
			command.CommandText = strSQL
			' Add your comments here
			command.ExecuteNonQuery()
			' Add your comments here
			conn.Close()
			SavePersonnel = True
		Catch ex As Exception
			SavePersonnel = False
		End Try
		‘Saying to add void here, but I am confused.’
	End Function

Thanks,
du_jleon

[Locke]

I think you're getting Function confused with Sub

To my knowledge, a Function must always return something. A Sub does not.

[Damage]

as far as my understanding of it goes,

if you're not returning a value use a sub

if you want to return a value the use a function

public function myFunc() as string
dim returnstring as string = ""

blah blah blah

return returnstring

end function

you declare your function and put the return type at the end (the as part)
i declare returnstring as empty, that way if it doesn't get updated i'm still returning something and my program won't bitch.

As for returning void, wellll i dunno. Void is a type and you would still have to declare a variable of that type i think. Someone correct me if i'm wrong here

This post has been edited by Damage: 26 March 2009 - 05:31 PM

[krum110487]

where is this 'SaveUserActivity' used at?

also where is the error occurring, step through the program and find out.

This post has been edited by krum110487: 27 March 2009 - 06:36 AM

[TheBeege]

Damage, on 26 Mar, 2009 - 04:30 PM, said:

as far as my understanding of it goes,

if you're not returning a value use a sub

if you want to return a value the use a function

public function myFunc() as string
dim returnstring as string = ""

blah blah blah

return returnstring

end function

you declare your function and put the return type at the end (the as part)
i declare returnstring as empty, that way if it doesn't get updated i'm still returning something and my program won't bitch.

As for returning void, wellll i dunno. Void is a type and you would still have to declare a variable of that type i think. Someone correct me if i'm wrong here

Void means... well, void. It means there's nothing there, i.e. nothing is returned. This is true of most, if not all, languages. There are void pointers in C, but that's a whole separate issue...

[jens]

Hi!

You say you get an error (or, I guess a warning) like this: "Warning 2 Function 'SaveUserActivity'..." and then you show us code for a function named SavePersonnel. Can you please show the code for function SaveUserActivity?

If you are not going to return anything use a Sub.
If you intend to return True / False you must declare your function as Boolean like this: Private Function SavePersonnel(ByVal Database As String, ByVal FirstName As String, ByVal LastName As String, ByVal PayRate As Integer, ByVal StartDate As DateTime, ByVal EndDate As DateTime) As Boolean

If you want to use a function - in order to return somthing - then you should have a Return statement, like - in this case - Return True and Return False.

Regards
/Jens

This post has been edited by jens: 01 April 2009 - 04:33 AM

[microstoc]

Sounds like the function SaveUserActivity is being exited before any value is assigned to SaveUserActivity

example:

Function SaveUserActivity as boolean

If (some test fails) then
'saveuseractivity has not been assigned a value here
Exit Function
Else
SaveUserActivity=true
Exit Function
End If

End Function

[du_jleon]

Thanks all that help it is work!!!