[stefaan]

I neeed some help with this problem. When i try to read all the records in a random access file in c it prints the last record twice in all the cases i've tried

#include <stdio.h>
#include <conio.h>


typedef struct
{
	char fname[12], lname[12];
}name;

FILE*info;

void main ()
{
	int i;
	name customer;
   if((info=fopen("Customers.dat", "wb"))==NULL)  //OPen file for writing
   	fprintf(stderr, "Error! Unable to store info");
   else{
   	for(i=0;i<2; i++){//Accept 2 records
   		printf("Please enter name: ");
   		scanf("%s %s", customer.fname, customer.lname);
   		fwrite(&customer, sizeof(name), 1, info);
	  }//end for loop
   } //end if
   fclose(info);							 //close file after writing   

   if((info=fopen("Customers.dat", "rb"))==NULL)  //Open file for reading
   	fprintf(stderr, "Error! Unable to open file");
   else{
   	while(!feof(info)){		//Print info read from file
   		fread(&customer, sizeof(name), 1, info);
		  printf("\nThe name enter is %s %s", customer.fname, customer.lname);
	  }//end while .
   }//end if
   fclose(info);
   getch();
} 

I dont know if i'm not using "feof" correctly

[janotte]

I haven't analysed this carefully but often these sorts of things can be resolved by flushing the buffers after each output using fflush.

Worth a try.

[stefaan]

janotte, on 16 Apr, 2009 - 06:41 AM, said:

I haven't analysed this carefully but often these sorts of things can be resolved by flushing the buffers after each output using fflush.

Worth a try.

I did that already but it didnt work

[mclang]

Are you sure the last record does not get written twice? Could you check this first for example by writing the records in plain text or calculating what the size of file with two structures should be. How about reading, does changing while() {} loop to do {} while() make any difference?

[stefaan]

mclang, on 16 Apr, 2009 - 11:39 PM, said:

Are you sure the last record does not get written twice? Could you check this first for example by writing the records in plain text or calculating what the size of file with two structures should be. How about reading, does changing while() {} loop to do {} while() make any difference?

No difference with while{} and do{}while

[stefaan]

I'm in need of great help here, I'll appreciate any comments.
I tried fflush, that didnt work, do{}while() instead of while and that didnt work either. Im sure the last record isn't written twice to the file because if i open the file in append mode and add a new record, it will print only the last one twice and not the one it printed twice before. This is very critical cuz i have a code to write that calculates total and this will throw me off by adding the last record twice.

[JackOfAllTrades]

FAQ #12.2: Why does the simple line-copying loop while(!feof(infp)) { fgets(buf, MAXLINE, infp); fputs(buf, outfp); } copy the last line twice?

[stefaan]

JackOfAllTrades, on 23 Apr, 2009 - 12:35 PM, said:

FAQ #12.2: Why does the simple line-copying loop while(!feof(infp)) { fgets(buf, MAXLINE, infp); fputs(buf, outfp); } copy the last line twice?

I'm not trying to read lines but rather reading complete records (random files). fgets() read lines at a time and this kind of file is not arranged in lines.

[janotte]

stefaan, on 24 Apr, 2009 - 05:32 AM, said:

I'm not trying to read lines but rather reading complete records (random files). fgets() read lines at a time and this kind of file is not arranged in lines.

Did you follow the link in JackOfAllTrades's posting?

[stefaan]

janotte, on 24 Apr, 2009 - 05:36 AM, said:

stefaan, on 24 Apr, 2009 - 05:32 AM, said:

I'm not trying to read lines but rather reading complete records (random files). fgets() read lines at a time and this kind of file is not arranged in lines.

Did you follow the link in JackOfAllTrades's posting?

Thank you very, it works just fine.
I was anxiously reading the post i miss the link. Thanx again
Bravo!!!