[systemerror]

This is my code

		private void Browse_Click(object sender, EventArgs e)
		{
			if (label2.Text == "0/20")
	   {
			if (openFileDialog1.ShowDialog() == DialogResult.OK)
			{
				textBox1.Text = openFileDialog1.FileName;

				if (label2.Text == "0/20")
				{
					label2.Text = "1/20";
				}
				else
				{
				   
				}
			}
		}

			if (label2.Text == "1/20")
			{
				if (openFileDialog1.ShowDialog() == DialogResult.OK)
				{
					textBox2.Text = openFileDialog1.FileName;

					if (label2.Text == "1/20")
					{
						label2.Text = "2/20";
					}
					else
					{

					}
				}
			}

			if (label2.Text == "2/20")
			{
				if (openFileDialog1.ShowDialog() == DialogResult.OK)
				{
					textBox1.Text = openFileDialog1.FileName;

					if (label2.Text == "2/20")
					{
						label2.Text = "3/20";
					}
					else
					{

					}
				}
			}

			if (label2.Text == "3/20")
			{
				if (openFileDialog1.ShowDialog() == DialogResult.OK)
				{
					textBox1.Text = openFileDialog1.FileName;

					if (label2.Text == "3/20")
					{
						label2.Text = "4/20";
					}
					else
					{

					}
				}
			}

			if (label2.Text == "4/20")
			{
				if (openFileDialog1.ShowDialog() == DialogResult.OK)
				{
					textBox1.Text = openFileDialog1.FileName;

					if (label2.Text == "4/20")
					{
						label2.Text = "5/20";
					}
					else
					{

					}
				}
			}

			if (label2.Text == "5/20")
			{
				if (openFileDialog1.ShowDialog() == DialogResult.OK)
				{
					textBox1.Text = openFileDialog1.FileName;

					if (label2.Text == "5/20")
					{
						label2.Text = "6/20";
					}
					else
					{

					}
				}
			}

There is a problem, I can't make the openfiledialog to stop opening up, I want it so that you click it once it opens for that textbox, click 2nd it opens for that 2nd text box and so on, can any help?

[Adkins]

The problem is that you are updateing your test value as the test is still going. I.E. it starts off with 0/20 you then change it to 1/20, then you test if it is equal to 1/20 and continue with this trend. It doesn't break out of this cycle till the end of the method.

[Crehl]

I don't quite understand what you're asking, but I'd like to point out 3 things:

1) You don't need those empty else statements (Unless you plan on using them at some later point), so you can remove them. Helps keep the code looking clean and easier to read.

2) You also don't need those inner if statements at all, as what you essentially have is:

			if (label2.Text == "1/20")
			{

				//Snip..

					if (label2.Text == "1/20")
					{
						label2.Text = "2/20";
					}

That second if is always going to be true (Since otherwise, the first wouldn't have been).

Thus, each if statement should look something like this:

			if (label2.Text == "1/20")
			{
				if (openFileDialog1.ShowDialog() == DialogResult.OK)
				{
					textBox2.Text = openFileDialog1.FileName;

					label2.Text = "2/20";
				}
			}

Already, it's starting to look simpler.

3) Your if statements are cascading (Don't believe that's an 'official' term for what's hapenning, but the best I know of). Let's have a look at what's hapening:

-You check if the label text is equal to "0/20"
-If so, open the dialog and then set the label text to "1/20"
-Check if the label test is equal to "1/20"
-Open dialog, etc etc

Each if statement changes the text such that the next if statement will always return true - opening up all the dialog boxes as a result (From what I can tell, I think this is the problem you described).

All that's needed is to merge all those if statements into an If/Elseif/ElseIf/.. and things should work as intended.

However, I wouldn't recommend that. A switch/case would be simpler, but with 21 possibilities (I assume you go up to 20/20?), I still wouldn't advise it.

Instead, use a for loop. It would also make sense to use a variable to check against rather than label text. It's better to use a variable to keep track of things because it stores only what is needed and so is easier to read/write. For example:

			if (curIteration == 1)
			{
				if (openFileDialog1.ShowDialog() == DialogResult.OK)
				{
					textBox2.Text = openFileDialog1.FileName;

					curIteration++;
					label2.Text = curIteration.ToString() + "/20";
				}
			}

A bit of a long post, but hopefully it should help with your problem and clean up the code a little,

-Crehl

[Edit] Looks like someone beat me to it, much more concisely

[b.ihde]

Edit your if-statements like this:

 if (label2.Text == "1/20")
			{

				//code
			}
  else if (label2.Text == "1/20")
			{
					  // code
			}
  else if (label2.Text == "2/20) .....

Greetz

Ben


Edit* you could also use switch-case statements here..

This post has been edited by b.ihde: 16 November 2009 - 09:23 AM