[macosxnerd101]

Please,

Since case two (below) onwards all follow the same pattern, you could use a loop to automate this. Just define a standard mathematical formula, then you can plug and play.

If ($_SESSION['Land'] >= 101 && $_SESSION['Land'] <= 150) 
$_SESSION['HLand'] = ($_SESSION['Land'] - 100) * 2 + 100;

[Stoutn]

macosxnerd101, on 08 June 2010 - 05:10 PM, said:

Please,

Since case two (below) onwards all follow the same pattern, you could use a loop to automate this. Just define a standard mathematical formula, then you can plug and play.

If ($_SESSION['Land'] >= 101 && $_SESSION['Land'] <= 150) 
$_SESSION['HLand'] = ($_SESSION['Land'] - 100) * 2 + 100;

Thanks for the suggestion, I should of thought of the code tags sooner lol


As for the code itself, I am not really sure of the pattern, hence my problem lol so for now the single if's seems to work well enough, until I see the pattern


new problem is:
Fatal error: Call to undefined function filter_input() in *site* on line 2

<?php
$RMili = filter_input(INPUT_GET, "inputMilitary");
$RWeap = filter_input(INPUT_GET, "inputWeapons");
$ROff = filter_input(INPUT_GET, "inputOffence");
$RDef = filter_input(INPUT_GET, "inputDefence");
$RRes = filter_input(INPUT_GET, "inputResidential");
$RAg = filter_input(INPUT_GET, "inputAgriculture");
$RInd = filter_input(INPUT_GET, "inputIndustrial");
$RMed = filter_input(INPUT_GET, "inputMedical");
$REsp = filter_input(INPUT_GET, "inputEspionage");
$RRef = filter_input(INPUT_GET, "inputRefinery");
$RLand = filter_input(INPUT_GET, "inputLand");
?>

This post has been edited by Stoutn: 08 June 2010 - 07:18 PM

[Atli]

Stoutn, on 08 June 2010 - 06:12 PM, said:

As for the code itself, I am not really sure of the pattern, hence my problem lol so for now the single if's seems to work well enough, until I see the pattern

Consider, if I were to put the parameters for your IF clauses into an array, like so:

$params = array(
    array("ceil" => 100, "multi" => 1, "add" => 0),
    array("ceil" => 150, "multi" => 2, "add" => 100),
    array("ceil" => 200, "multi" => 3, "add" => 200),
    // etc...
);

The "ceil" would be the ceiling, the higher end of the value of "land" allowed by your IF statements.
The "multi" and "add" would be the values used in your formula.

With that, you can use a simple loop to do the calculations, which would remain the same even if you need to change/add to the parameters..
Can't seem to explain that in words at the moment, so I'll just show you what I mean xD

$land = $_SESSION['Land'];
$hland = null;

// Search for the first ceiling that is higher than the
// "land" value.
foreach($params as $_i => $_values)
{
    if($land <= $_values['ceil'])
    {
        // No reduction for the first element, so use 0
        // if this is the first element. Othervise get 
        // the ceiling for the previous param.
        $reduction = $_i == 0 ? 0 : $params[$_i-1]['ceil'];

        // The standard formula
        $hland = ($land - $reduction) * $_values['multi'] + $_values['add'];

        // Break out of the loop, or you will always 
        // end up with the highest posibility.
        break;
    }
}
$_SESSION['HLand'] = $hland;

This way you could alter the parameters for the calculations without actually having to modify the code itself (only the array). You could even pull it from a database, or something along those lines.

[Stoutn]

That is quite interesting, I will have to read up on that Thank you very much for pointing it out to me

Atli, on 08 June 2010 - 10:58 PM, said:

Stoutn, on 08 June 2010 - 06:12 PM, said:

As for the code itself, I am not really sure of the pattern, hence my problem lol so for now the single if's seems to work well enough, until I see the pattern

Consider, if I were to put the parameters for your IF clauses into an array, like so:

$params = array(
    array("ceil" => 100, "multi" => 1, "add" => 0),
    array("ceil" => 150, "multi" => 2, "add" => 100),
    array("ceil" => 200, "multi" => 3, "add" => 200),
    // etc...
);

The "ceil" would be the ceiling, the higher end of the value of "land" allowed by your IF statements.
The "multi" and "add" would be the values used in your formula.

With that, you can use a simple loop to do the calculations, which would remain the same even if you need to change/add to the parameters..
Can't seem to explain that in words at the moment, so I'll just show you what I mean xD

$land = $_SESSION['Land'];
$hland = null;

// Search for the first ceiling that is higher than the
// "land" value.
foreach($params as $_i => $_values)
{
    if($land <= $_values['ceil'])
    {
        // No reduction for the first element, so use 0
        // if this is the first element. Othervise get 
        // the ceiling for the previous param.
        $reduction = $_i == 0 ? 0 : $params[$_i-1]['ceil'];

        // The standard formula
        $hland = ($land - $reduction) * $_values['multi'] + $_values['add'];

        // Break out of the loop, or you will always 
        // end up with the highest posibility.
        break;
    }
}
$_SESSION['HLand'] = $hland;

This way you could alter the parameters for the calculations without actually having to modify the code itself (only the array). You could even pull it from a database, or something along those lines.