[Phillyfries]

My program is ignoring information in the loop. Any suggestions?

#include <iostream>
#include <cstdlib>
#include <ctime>
#include <cstdlib>
#include <cmath>

using namespace std;

    const int NUMBER_GAMES = 10000;
    int dice1 = 1 + rand() % 6; // 1st dice roll
    int dice2 = 1 + rand() % 6; // 2nd dice roll
    int dice3 = 1 + rand() % 6; // 3rd dice roll
    int dice4 = 1 + rand() % 6; // 4th dice roll
    
int main()
{
    //variables
    int numberWins = 0;
    int numberLosses = 0;
    int point = 0;
    int dice1, dice2, dice3, dice4;
    int roll = dice1 + dice2;
    int sum = roll; // compute sum of die values
    int newRoll = dice3 + dice4;
    

    // conditions of the game
    for (int roll = 1; roll <= 10000; roll++)

         cout << "Start the roll: \n";
         sum = roll;
     if ((dice1 + dice2) == 7 || ( dice1 + dice2) == 11)
      {
        numberWins = numberWins + 1;
        cout << "You won !" << endl;
      }
      if ((dice1 + dice2) == 2 || ( dice1 + dice2) == 3|| ( dice1 + dice2) == 12)
      {
         numberLosses = numberLosses +1;
         cout << "You lose !" << endl;
      }
      // Establish the Point
      else if((dice1 + dice2) == 4 || ( dice1 + dice2) == 5|| ( dice1 + dice2) == 6 || ( dice1 + dice2) == 8||( dice1 + dice2) == 9 ||( dice1 + dice2) == 10)
        {
           roll = point;
           cout << "This is your point" <<endl;
           do
           {
            newRoll = dice3 + dice4;
           }
           while (newRoll != 7 && newRoll != point);

           if ( newRoll == 7)
           {
                numberLosses = numberLosses +1;
                cout << "You did not make your point. You lost" <<endl;
           }
           else if ( newRoll == point)
           {
                numberWins = numberWins + 1;
                cout << "You made your point. You win" <<endl;
           }
        }

        return 0;
}
    int probability ()
    {
        double winningPercentage;
        int numberWins;
        winningPercentage = numberWins/NUMBER_GAMES;
        system("pause");
        return 0;
    }

This post has been edited by JackOfAllTrades: 11 October 2010 - 07:16 AM
Reason for edit:: Fixed code tags.

[Alex6788]

The code tags are wrong, Like this

This post has been edited by Alex6788: 11 October 2010 - 07:15 AM

[JackOfAllTrades]

Please be more specific. You have multiple loops, for one thing.

[Phillyfries]

The program repeats "start the roll" 10000 times.

[jimblumberg]

Phillyfries, on 11 October 2010 - 01:20 PM, said:

The program repeats "start the roll" 10000 times.

// conditions of the game
    for (int roll = 1; roll <= 10000; roll++)

You need to add {} otherwise you will only execute the next line multiple times.

You also have quite a few uninitialized memory variables in your code.

Jim

[Phillyfries]

I added the {}. I still the same problem (The program repeats "start the roll" 10000 times. )

[Alex6788]

In your header files you declare cstdlib twice

#include <iostream>
#include <cstdlib> // Here
#include <ctime>
#include <cstdlib>  // Here declared twice
#include <cmath>

Hope that helped.

This post has been edited by Alex6788: 11 October 2010 - 07:52 AM

[jimblumberg]

Please post the code where you added the {}.

Jim

[Phillyfries]

// conditions of the game
    for (int roll = 1; roll <= 10000; roll++)
      {
         cout << "Start the roll: \n";
         sum = roll;
      }

[Mohanddo]

You have already declared roll, why are you declaring it again for the loop?

[Phillyfries]

Ok. Now how do I start the roll process?
Thanks

[jimblumberg]

You probably want your {} like:

for (int roll = 1; roll <= 10000; roll++)
{

         cout << "Start the roll: \n";
         sum = roll;
     if ((dice1 + dice2) == 7 || ( dice1 + dice2) == 11)
      {
        numberWins = numberWins + 1;
        cout << "You won !" << endl;
      }
      if ((dice1 + dice2) == 2 || ( dice1 + dice2) == 3|| ( dice1 + dice2) == 12)
      {
         numberLosses = numberLosses +1;
         cout << "You lose !" << endl;
      }
      // Establish the Point
      else if((dice1 + dice2) == 4 || ( dice1 + dice2) == 5|| ( dice1 + dice2) == 6 || ( dice1 + dice2) == 8||( dice1 + dice2) == 9 ||( dice1 + dice2) == 10)
        {
           roll = point;
           cout << "This is your point" <<endl;
           do
           {
            newRoll = dice3 + dice4;
           }
           while (newRoll != 7 && newRoll != point);

           if ( newRoll == 7)
           {
                numberLosses = numberLosses +1;
                cout << "You did not make your point. You lost" <<endl;
           }
           else if ( newRoll == point)
           {
                numberWins = numberWins + 1;
                cout << "You made your point. You win" <<endl;
           }
        }
}// end of for

Also look here

  int dice1, dice2, dice3, dice4;
    int roll = dice1 + dice2;

in this snippet you are using your variables before you initialize them. You should always initialize your variables when defining them.

   int dice1 = 0;
   int dice2 = 0;
   int dice3 = 0; 
   int dice4 = 0;
   int roll = dice1 + dice2;

Jim

[aaa111]

You have to put {} within the portion which you want to repeat,i guess you want to repeat the 30-63 line 10000 times,also none of your if else if chain working at all.
Also if you want dice1...dice4 values to change randomly within this 10000 iteration you have to generate the random number within that {} brace.If you don't want to produce same random number follow this tutorial:
http://www.dreaminco...random-numbers/

This post has been edited by aaa111: 11 October 2010 - 08:32 AM

[jimblumberg]

    const int NUMBER_GAMES = 10000;
    int dice1 = 1 + rand() % 6; // 1st dice roll
    int dice2 = 1 + rand() % 6; // 2nd dice roll
    int dice3 = 1 + rand() % 6; // 3rd dice roll
    int dice4 = 1 + rand() % 6; // 4th dice roll
    
int main()
{
    //variables
    int numberWins = 0;
    int numberLosses = 0;
    int point = 0;
    int dice1, dice2, dice3, dice4;
    int roll = dice1 + dice2;
    int sum = roll; // compute sum of die values
    int newRoll = dice3 + dice4;
    

In the above snippet you have GLOBAL variables hidden by your local variables(they have the same name). I would remove the GLOBALS and stick with local variables.

Jim

[Phillyfries]

Added the srand. Not sure about comment re lines 30-63. Amended code below. The "start the roll" 10000 times is still there.

#include <iostream>
#include <cstdlib>
#include <ctime>
#include <cmath>

using namespace std;

    const int NUMBER_GAMES = 10000;
    int dice1 = 1 + rand() % 6; // 1st dice roll
    int dice2 = 1 + rand() % 6; // 2nd dice roll
    int dice3 = 1 + rand() % 6; // 3rd dice roll
    int dice4 = 1 + rand() % 6; // 4th dice roll

int main()
{
    //variables
    int numberWins = 0;
    int numberLosses = 0;
    int point = 0;
    int dice1 =0, dice2 =0, dice3 =0, dice4 =0;
    int roll = dice1 + dice2;
    int sum = roll; // compute sum of die values
    int newRoll = dice3 + dice4;


    // conditions of the game
    for (int roll = 1; roll <= 10000; roll++)
    {
         srand(time(0));
         cout << "Start the roll: \n";
         sum = dice1 + dice2;
         cout << "The roll was " << sum << ' ' << endl;

     if ((dice1 + dice2) == 7 || ( dice1 + dice2) == 11)
      {
        numberWins = numberWins + 1;
        cout << "You won !" << endl;
      }
      if ((dice1 + dice2) == 2 || ( dice1 + dice2) == 3|| ( dice1 + dice2) == 12)
      {
         numberLosses = numberLosses +1;
         cout << "You lose !" << endl;
      }
      // Establish the Point
      else if((dice1 + dice2) == 4 || ( dice1 + dice2) == 5|| ( dice1 + dice2) == 6 || ( dice1 + dice2) == 8||( dice1 + dice2) == 9 ||( dice1 + dice2) == 10)
        {
           roll = point;
           cout << "This is your point" <<endl;
           do
           {
            newRoll = dice3 + dice4;
           }
           while (newRoll != 7 && newRoll != point);

           if ( newRoll == 7)
           {
                numberLosses = numberLosses +1;
                cout << "You did not make your point. You lost" <<endl;
           }
           else if ( newRoll == point)
           {
                numberWins = numberWins + 1;
                cout << "You made your point. You win" <<endl;
           }
        }

 }       return 0;
}
    int probability ()
    {
        double winningPercentage;
        int numberWins;
        winningPercentage = numberWins/NUMBER_GAMES;
        system("pause");
        return 0;
    }