[Hanoble]

Hello everyone, I have been in a programming course for just over a month now and I am creating a yahtzee program for one of my assignments. Things have been moving along decently for my, but I have hit a bit of a snag. It comes when calculating the scores and using the or operator. When tallying the scores for three of a kind my code looks like this:

case 7:
			if (die[0] == die[1] == die[2] || die[1] == die[2] == die[3] || die[2] == die[3] == die[4])
			{
				threeKind = (die[0]+die[1]+die[2]+die[3]+die[4]);
				cout << "Your Three of a Kind score was " << threeKind << endl;
			}
			else
			{
				threeKind = 0;
				cout << "Your Three of a Kind score was " << threeKind << endl;
			}
			break;

The problem is that this only seems to work for the very first part of code the die[0] == die[1] == die[2] section. Any time I get one of the other two matches it skips the if and goes straight to the else and gives a score of zero. Anyone got any idea what is going on here? I have tried everything I know and looked around for help, but I can't find what I need. Any help would be greatly appreciated!

[Ap0C552]

Before the conditional print out the values of all the dice.

Also break up the conditional into three separate if statements that will print out

" dice 0 1 2 match"

"dice 1 2 3 match"

"dice 3 4 5 match"

Also keep in the original if statement as well.

This will surely help you see what is going wrong.

This post has been edited by Ap0C552: 19 November 2011 - 11:45 AM

[Hanoble]

Ap0C552, on 19 November 2011 - 11:44 AM, said:

Before the conditional print out the values of all the dice.

Also break up the conditional into three separate if statements that will print out

" dice 0 1 2 match"

"dice 1 2 3 match"

"dice 3 4 5 match"

Also keep in the original if statement as well.

This will surely help you see what is going wrong.

I have done this and the if only executes if die[0] == die[1] == die[2]. I have also got rid of the or operator and attempted to use else if for each additional statement and it still only works with the original if statement. I have no clue why, but hopefully someone here does.

[Ap0C552]

Well if you have IDENTICAL if statements that says

if(die[0] == die[1] == die[2])
{

}

if(die[1] == die[2] == die[3])
{

}

if(die[3] == die[4] == die[5])
{

}

And only the first conditional runs I am going to venture to say that the dice are not equal in the other cases.

Print out the values of the dice right before each conditional.

[Hanoble]

Ap0C552, on 19 November 2011 - 12:41 PM, said:

Well if you have IDENTICAL if statements that says

if(die[0] == die[1] == die[2])
{

}

if(die[1] == die[2] == die[3])
{

}

if(die[3] == die[4] == die[5])
{

}

And only the first conditional runs I am going to venture to say that the dice are not equal in the other cases.

Print out the values of the dice right before each conditional.

Hello Ap0C, thanks for helping. This is my new code as you suggested.

case 7:
			sort (die, die+5);
			cout << die[0] << die[1] << die[2] << die[3] << die[4] << endl;
			if (die[0] == die[1] == die[2]) 
			{
				threeKind = (die[0]+die[1]+die[2]+die[3]+die[4]);
				cout << "Your Three of a Kind score was " << threeKind << endl;
			}
			else if (die[1] == die[2] == die[3])
			{
				threeKind = (die[0]+die[1]+die[2]+die[3]+die[4]);
				cout << "Your Three of a Kind score was " << threeKind << endl;
			}
			else if (die[2] == die[3] == die[4])
			{
				threeKind = (die[0]+die[1]+die[2]+die[3]+die[4]);
				cout << "Your Three of a Kind score was " << threeKind << endl;
			}
			else
			{
				threeKind = 0;
				cout << "Your Three of a Kind score was " << threeKind << endl;
			}
			break;

I also added the way I am sorting the die at the top of the case statement just in case this has anything to do with it. Anyway, I ran this and I got 13334. This should of set off the second if statement, but it did not and instead went to the else statement and gave the roll a score of zero. However, when I rolled and got 11146 from sort it set my three of a kind score to 13 as it should. So these are the exact same results I was getting out of my original code using the OR operator.

[Hanoble]

Any other suggestions? Still unable to get this to correctly calculate and unable to find a way around it. Any help would be greatly appreciated!

[jimblumberg]

In C/C++ you if statement should look more like:

if( ( (die[0] == die[1]) && (die[0] == die[2]) ) || 
    ( (die[1] == die[2]) && (die[1] == die[3]) ) )

Each section of statement must be complete.

Jim

[Hanoble]

jimblumberg, on 19 November 2011 - 05:27 PM, said:

In C/C++ you if statement should look more like:

if( ( (die[0] == die[1]) && (die[0] == die[2]) ) || 
    ( (die[1] == die[2]) && (die[1] == die[3]) ) )

Each section of statement must be complete.

Jim

THANK YOU JIM! That fixed it and I was having this trouble throughout all of my calculations after the first if so thanks a lot. I've been stuck trying to figure this out for hours, but glad that you were able to help. I really appreciate it!