[saljanjan]

[When I compile the program compiler just sit there and does not do anything; not giving me the sum of the elements in the array. How can get the sum of this array?

#include <iostream>
using namespace std;

int main() {
    int a[1000];       // Declare an array of 1000 ints
    int n = 0;         // Number of values in a.

    while (cin >> a[n]) {
        n++;
    }

    int sum = 0;       // Start the total sum at 0.
    for (int i=0; i<n; i++) {
        sum = sum + a[i];  // Add the next element to the total
    }
    
    cout << sum << endl;
    
    return 0;
} 

MOD EDIT: Added code tags. When posting code...USE CODE TAGS!!!

This post has been edited by JackOfAllTrades: 25 November 2011 - 04:57 AM

[CTphpnwb]

Please use code tags.

When is cin >> a[n] going to be false? Is the loop going to continue while it's true?

[Martyr2]

And what makes you think this loop...

while (cin >> a[n]) {
   n++;
}

is ever going to end? Just because "n" is higher than the number of spots in the array? Nothing here says that. This will just keep on writing right into memory.

Translation to you, the program will continue to accept input until you get tired of entering values or you run out of memory to write to.



P.S. It is dangerous to be running code you "found on the Internet" without having a clue as to what it could possibly be doing.

This post has been edited by Martyr2: 24 November 2011 - 10:49 PM

[David W]

Also ... if you were to enter 1001 entries into your array ... do you want to prevent that?
Also ... best practice is not to use 'magic numbers' ...

Instead code like this ...

const int MAX_SIZE = 1000; // max num of array elements

// ...

int ary[ MAX_SIZE ];

[JackOfAllTrades]

Quote

When I compile the program compiler just sit there and does not do anything; not giving me the sum of the elements in the array.

Compiling only builds the executable, it does not actually run the program! Unless, of course, you chose an option like Compile and Run, which I think is an option in some IDEs.

If you did actually run the program, I'm guessing you might need to read this.

[newuser007]

#include <iostream>
using namespace std;

int main() 
{
	const int s=3;     //Declare s=999 for array of 1000 ints
    int a[s];        
    int n = 0;         // Number of values in a.


	do
	{
		cout<<"\nENTER ELEMENT "<<n+1<<":";
		cin>>a[n];
		n++;
	}while(n<4);		//replace it with n<1000
    //while (cin >> a[n]) {
    //    n++;
   // }

    int sum = 0;       // Start the total sum at 0.
    for (int i=0; i<n; i++) 
	{
        sum = sum + a[i];  // Add the next element to the total
    }
    
    cout <<"\nSUM:"<< sum << endl;
    
    return 0;
} 

Quote

I've re-edited your code...n its working fine..

[CTphpnwb]

newuser007, it's not very helpful to hand somebody working code. They're not going to learn anything from it. Even worse, it encourages others to post "gimme teh codez" questions. We get plenty of those as it is.