[redtoshiba]

There is already an open DataReader associated with this Command which must be closed first

 Dim staffid = TextBox1.Text
    Dim conn As New SqlConnection
    conn.ConnectionString = SqlDataSource1.ConnectionString

    Dim command1 As New SqlCommand("SELECT StaffDetails.StaffID, SUM(HolidayRequests.RequestTotalDays) AS Expr1 FROM HolidayRequests INNER JOIN StaffDetails ON HolidayRequests.Username = StaffDetails.UserName WHERE (StaffDetails.StaffID = staffID) GROUP BY StaffDetails.StaffID, HolidayRequests.ApprovalStatus HAVING (HolidayRequests.ApprovalStatus = N'approved')", conn)

    conn.Open()
    Dim rdr As SqlDataReader
    rdr = command1.ExecuteReader
    Dim UpdateQuery As String
    While (rdr.Read())

        UpdateQuery = "UPDATE HolidayEntitlement set Holiday_Taken = @Expr1"
        command1.Parameters.AddWithValue("@Expr1", rdr("Expr1").ToString())

        'run update query

        command1.CommandText = UpdateQuery
        command1.ExecuteNonQuery()

         conn.close()
    End While 

It stops at command1.ExecuteNonQuery()

I've tried changing the where the connections/commands open and close and had had no success

Any Suggestions

[modi123_1]

How about rediming the command object somewhere around line 9 or 10? You know breaking that command-reader relationship.

[trevster344]

What is it the last few weeks with everyone declaring variables like this:

Dim staffid = TextBox1.Text  

What kind of variable is that? I want to know so bad. ;P

Dim staffid as String = TextBox1.Text

[nK0de]

trevster344, on 13 March 2012 - 09:55 PM, said:

What is it the last few weeks with everyone declaring variables like this:

Dim staffid = TextBox1.Text  

What kind of variable is that? I want to know so bad. ;P

Dim staffid as String = TextBox1.Text

Actually it is possible to declare variables like that in VB.NET without defining its type. But I don't think its good practice though.

[trevster344]

A terribly lazy and fatal practice. My point exactly.