[dman187]

i keep getting an infinite loop when i try this binary search. can you help me to see where my logic is wrong?

public static int binarySearch( String[] input, String searchFor ) {
		if(null == input)
			return -1;

		int low =0;
		int high = input.length;
		int middle = (high+low)/2;

		while(high >low){
			if(input[middle].equals(searchFor)){
				return middle;}
			if (input[middle].compareTo(searchFor)>0){
				high = middle;
			}
			else {

				low = middle;
			}
			middle = (high+low)/2;
			
		}

		return -1;
	}	// end binarySearch

[SwiftStriker00]

In your algorithm you don't want to set low=middle, because, that will get it stuck when you search for something that doesnt exist. You want to search 1 away from the middle

if (input[middle].compareTo(searchFor)>0)
 {
	 high = middle-1;
 }
 else
 {
  low = middle + 1;
 }