[jmart]

I created this code in class and it compiled just how I have it written, but now I am home wanting to add a couple more things to it and I keep getting these errors:

RockPaperScissors.java:17: incompatible types
found   : java.lang.String
required: int
		switch(userChoice){
		       ^
RockPaperScissors.java:19: incompatible types
found   : java.lang.String
required: int
			switch(computerChoice){
			       ^
RockPaperScissors.java:25: incompatible types
found   : java.lang.String
required: int
			switch(computerChoice){
			       ^
RockPaperScissors.java:31: incompatible types
found   : java.lang.String
required: int
			switch(computerChoice){
			       ^
RockPaperScissors.java:41: incompatible types
found   : java.lang.String
required: int
			switch(userChoice){
			       ^
RockPaperScissors.java:44: incompatible types
found   : java.lang.String
required: int
				switch(computerChoice){
				       ^
RockPaperScissors.java:50: incompatible types
found   : java.lang.String
required: int
				switch(computerChoice){
				       ^
RockPaperScissors.java:56: incompatible types
found   : java.lang.String
required: int
				switch(computerChoice){
				       ^
RockPaperScissors.java:65: incompatible types
found   : java.lang.String
required: int
		switch(userChoice){
		       ^
RockPaperScissors.java:67: incompatible types
found   : java.lang.String
required: int
			switch(computerChoice){
			       ^
RockPaperScissors.java:73: incompatible types
found   : java.lang.String
required: int
			switch(computerChoice){
			       ^
RockPaperScissors.java:79: incompatible types
found   : java.lang.String
required: int
			switch(computerChoice){
			       ^
12 errors

I've been looking up anything to help me but I can't seem to figure it out...I know it may be something simple that I am over thinking, but anyone have any insight on this?
Like I said, my code is not yet done. I still need to add random and a return but here is my code thus far:

import java.util.Scanner;
import java.util.Random;

public class RockPaperScissors
{
	
	public static void main(String[] args)
	{
	Scanner keyboard = new Scanner(System.in);
	
	String winner = "computer";
	String computerChoice = "paper";
	String userChoice = "rock";
	System.out.println("Enter your choice");
	userChoice = keyboard.next();
		
		switch(userChoice){
		case "rock":
			switch(computerChoice){
			case "scissors":
			winner = "user";
			System.out.println("Computer chose scissors");
			break;
			}
			switch(computerChoice){
			case "paper":
			winner = "computer";
			System.out.println("Computer chose paper");
			break;
			}
			switch(computerChoice){
			case "rock":
			winner = "tie";
			System.out.println("Computer chose rock");
			break;
			}
			
			System.out.println("The winner is " + winner);
			}
			
			switch(userChoice){
		
			case "paper":
				switch(computerChoice){
				case "rock":
				winner = "user";
				System.out.println("Computer chose rock");
				break;
				}
				switch(computerChoice){
				case "scissors":
				winner = "user";
				System.out.println("Computer chose scissors");
				break;
				}
				switch(computerChoice){
				case "paper":
				winner = "tie";
				System.out.println("Computer chose paper");
				break;
				}
				System.out.println("The winner is " + winner);
				}
			
		switch(userChoice){
		case "scissors":
			switch(computerChoice){
			case "paper":
			winner = "user";
			System.out.println("Computer chose paper");
			break;
			}
			switch(computerChoice){
			case "rock":
			winner = "computer";
			System.out.println("Computer chose rock");
			break;
			}
			switch(computerChoice){
			case "paper":
			winner = "tie";
			System.out.println("Computer chose paper");
			break;
			}
			System.out.println("The winner is " + winner);
			}
	}
}

Thanks in advance.

[pbl]

If your JDK is 1.6 or lower you can't switch() on a String

P.S.
switching on a String is probably not the best solution

[Ytry]

Yeah in java 1.6 you can only switch int, boolean, double, long, and float I believe.

[jmart]

Got it thanks for the tip

[macosxnerd101]

Ytry, on 11 October 2012 - 11:59 PM, said:

Yeah in java 1.6 you can only switch int, boolean, double, long, and float I believe.

Not even those. Just int, byte, short, and char.

[pbl]

int which may be an enum constant of course

[raghav.naganathan]

I would suggest you to to change your print statement to something like this.

  System.out.println("Enter your choice in the following way.");
  System.out.println("1.rock 2.Paper 3.Scissors");

Now, use the values of 1,2 and 3 in your switch statements so you can avoid string altogether.

regards,
Raghav

[jmart]

How do I get it to pick a random choice for the computer?

[macosxnerd101]

See the Random class: http://docs.oracle.c...til/Random.html

int choice = rand.nextInt(3) + 1; //rand.nextInt(3) generates a random from 0-2