[u_haluk]

I'm getting en error that says: type Bag does not take parameters, what would be the error?
Here is the code:

public class ConsonantCounter implements Bag<String>
{
    private Bag<String> letters;
    private Bag<String> vowels;
    private Bag<String> consonants;
    
    
    public ConsonantCounter()
    {
        letters = new Bag<String>();
        vowels = new Bag<String>();
        consonants = new Bag<String>();
    }
    
    public Bag<String> getConsonants(String str)
    {
     String upStrings = str.trim().toUpperCase();
    
     
      vowels.add("A");
      vowels.add("E");
      vowels.add("I");
      vowels.add("O");
      vowels.add("U");
      
    
     for(int index=0; index < str.length(); index++)
      {
     String characterString = upStrings.substring(index, index + 1);
     Character character = characterString.charAt(0);
     if (Character.isLetter(character))
     {
         String newchar = character.toString();
         letters.add(newchar);
    
     }
      }
     
     for(int index2 = 0; index2< letters.getCurrentSize(); index2++)
     {
         
     }
     
     
        
        
    }
    public String toUpperCase()
    {
    }
    /**
     * getFrequency returns the frequency of the given consonant 
     * 
     * @param    true
     * @return   frequency of a consonant in the string  
     */
    public int getFrequency(String consonant)
    {
       
        
    }
}

[GregBrannon]

There are many errors. Can you describe what this bit of code is supposed to be (or become)? Start with describing what Bag is.

[sepp2k]

The error would be that you defined the Bag interface without type parameters (i.e. interface Bag {...}, not interace Bag<T> {..}), but you're using it with type parameters. That's what the error message is saying anyway.

This post has been edited by sepp2k: 16 December 2012 - 09:08 AM
Reason for edit:: s/class/interface/g

[u_haluk]

GregBrannon, on 16 December 2012 - 09:04 AM, said:

There are many errors. Can you describe what this bit of code is supposed to be (or become)? Start with describing what Bag is.

This method will create a bag containing all of the consonants in the String str, converted to upper case. Note that str may contain characters that are not letters as well as lower-case letters. As an example, str could be “The quick brown fox, named Red Tail, jumped over the lazy dachshund, named Weiner.”

[u_haluk]

any other replies appreciated.

[sepp2k]

u_haluk, on 16 December 2012 - 06:58 PM, said:

any other replies appreciated.

Why? Did I not answer your question?

[u_haluk]

sepp2k, on 16 December 2012 - 10:59 AM, said:

u_haluk, on 16 December 2012 - 06:58 PM, said:

any other replies appreciated.

Why? Did I not answer your question?

I didn't want to be mean. I need to know more about it like how would I implement it correctly? I don't really know how to define its parameter and can't really find what to do.

[sepp2k]

u_haluk, on 16 December 2012 - 07:03 PM, said:

I didn't want to be mean. I need to know more about it like how would I implement it correctly?

How did you implement it now? You never showed us the definition of your Bag interface.

Anyway, if you want to use your interface as Bag<String>, you'll have to define it as interface Bag<T> and then use T in the signatures of your methods.

Wait... after reading your code again, I'm suddenly no longer even sure whether Bag is an interface or a class. You use it like a class in some cases (e.g. you instantiate it with new), but at the beginning you say that your class is implementing ]Bag<String>, which would certainly imply that it's an interface. However none of your class's methods actually look like they'd be specified by the Bag interface (if it is one).

This post has been edited by sepp2k: 16 December 2012 - 11:09 AM

[u_haluk]

sepp2k, on 16 December 2012 - 11:05 AM, said:

u_haluk, on 16 December 2012 - 07:03 PM, said:

I didn't want to be mean. I need to know more about it like how would I implement it correctly?

How did you implement it now? You never showed us the definition of your Bag interface.

Anyway, if you want to use your interface as Bag<String>, you'll have to define it as interface Bag<T> and then use T in the signatures of your methods.

Thanks again for the reply. If you still are interested knowing the definition, it is:
/**
* ConsonantCounter is a program that takes in a string, discards the vowels in the string,
* counts the number of consonants in the string and displays them.
*/

I will try what you have said. Thanks again!