[shivesh_ssj]

hey !! its me !! hi all.....!!
morn'n !
i've got the code ...and its my 1st code ..so pls anyone can check it?
thnx in advance ..... :smartas

//******************************
//         -=shivesh=-
//******************************
//          source code
//******************************
#include <iostream.h>
#include <conio.h>

void main()
{
	clrscr();

	long amt,n1,n2,n3,n4,n5,n6,n7,n8,n9,tot;

	cout<<"enter the amount :-\n";
	cin>>amt;

	n1=amt/1000;
	amt=amt%1000;

	n2=amt/500;
	amt=amt%500;

	n3=amt/100;
	amt=amt%100;

	n4=amt/50;
	amt=amt%50;

	n5=amt/20;
	amt=amt%20;

	n6=amt/10;
	amt=amt%10;

	n7=amt/5;
	amt=amt%5;

	n8=amt/2;

	n9=amt%2;

	tot=n1+n2+n3+n4+n5+n6+n7+n8+n9;

	cout<<"\n\nTHE TOTAL NUMBER OF NOTES ARE :-\n\n";
	cout<<"no. of 1000 notes = "<<n1<<endl<<"no. of 500 notes = "<<n2<<endl<<"no. of 100 notes = "<<n3<<endl<<"no. of 50 notes = "<<n4<<endl<<"no. of 20 notes = "<<n5<<endl<<"no. of 10 notes = "<<n6<<endl<<"no. of 5 notes = "<<n7<<endl<<"no. of 2 notes = "<<n8<<endl<<"no. of 1 notes = "<<n9<<endl<<"no. of total notes = "<<tot;

	getch();
}
//**********************************
//             #END#
//**********************************

[tarmizi_adam2005]

Hi,

Are you running into any problems ? I don't really understand what your program does but I suggest that you stick to C/C++ standards. Instead of using void main() which is wrong and non C/C++ standard, your main function should be declared to return an integer. So,

int main()
{
   // your code
   return 0;
}

Are you using the ancient turbo C/C++ compiler ? If so, I would recommend that you switch to a more modern compiler which sticks to the current C/C++ standard. Finally, I think you could make use of functions and loops.

[Skydiver]

Using more descriptive names for your variables may also help. Yes, your ancient Turbo C compiler may only consider the first 31 characters significant (unless you have the really really old version that had an 8 character limit), but you can still make full use of those 31 characters instead of just limiting yourself to just 2 characters.

[shivesh_ssj]

oh...thnx for the reviews ....!!
actually i'm not a pro like u....i'm still a school go'n kid...xD
so...my school force me to get that rubbish turbo c++ compiler...(sry for that)
and pls can anyone tell me the difference b/w void and int....i mean wht is void ...lolz

[vividexstance]

void means the function doesn't return any values. The main() function, according to the standards, is suppose to return an integer value that indicates whether the program exited successfully or if there was an error.

[macosxnerd101]

shivesh_ssj, on 27 April 2014 - 11:57 AM, said:

oh...thnx for the reviews ....!!
actually i'm not a pro like u....i'm still a school go'n kid...xD />
so...my school force me to get that rubbish turbo c++ compiler...(sry for that)
and pls can anyone tell me the difference b/w void and int....i mean wht is void ...lolz />

I understand English may not be your native language, but please try and type in in something resembling proper grammar, and not chat-speak. We're a forum of professionals, not middle school kids on a chat client.