[jago the tiger]

I am a beginner at this so don't judge. c:
But I have started to use rand and stuff, so here is my program:

#include <iostream>
#include <fstream>
#include <istream>
#include <cstdlib>
#include <ctime>

using namespace std;
void getComNum();
void ask();
void test();

bool again;
int userNum;
int comNum;


int main (){
    void ask();
    void getComNum();
    void test();
    
   
};


void ask(){
    cout << "Hello, I am thinking of a number between 1 and 100.."<< endl;
    cout << "..what number do you think it is?? " << endl;
    
};


void test(){
    while(again==true)
    cin >> userNum;
    
    if(userNum > comNum || userNum < comNum){
        cout<<"try again "<<endl;
        again=true;
    }else{cout<<"You are correct"<<endl;}
}



void getComNum(){
    srand(time(0));
    comNum = 1+(rand()%100);
    
};

Tell me any problems or anything you notice I'm missing and tips.
THANK YOU "I'm new"

[infernorthor]

Don't have the return type when calling a function.

Don't use global variables, have passed values or locals.

Assign variables before using them.

[JackRV]

infernorthor brought up some very good points that all need to be addressed and I just have one more which is that in your while loop you start with

while(again==true)

So we need to start with again being equal to true at first so when we declare it we should declare it as

bool again = true;

Also if the user guesses correctly the while loop wont terminate because again is still equal to true so inside the else statement you need to add a

again = false;

[#define]

Hi, what problems are you having?

[jago the tiger]

Thanks guys.
any tips unsparing and placing my code. To me it looks cludered.

jago the tiger, on 11 May 2015 - 06:50 PM, said:

CORRECTION:
Thanks guys.
any tips on spacing and placing my code. To me it looks cludered.

[infernorthor]

please post updated code

[jago the tiger]

infernorthor, on 11 May 2015 - 06:56 PM, said:

please post updated code

SORRY, i am having problems with this code.
I wrote this crap in a lazy and stupid way, i wasn't really doing
my best. It is just plain sloppy. is it ok if i rewrite it then post it, unless you want me to figure out this junk.

[infernorthor]

Rewrite everything if you want, I don't care. It is just hard to comment on old code that people already offered advice, or not having specific problems or questions.

[jago the tiger]

whats the difference between of

#include <string>

and

#include <string.h>

[no2pencil]

First is C++, second is C.

[jago the tiger]

no2pencil, on 11 May 2015 - 07:44 PM, said:

First is C++, second is C.

Thanks

[jago the tiger]

Allright I got this so far :

#include <iostream>
#include <fstream>
#include <istream>
#include <cstdlib>
#include <ctime>
#include <string.h>

using namespace std;
string ask();
int getUseNum ();
int randNum();


int main(){
    bool loop=true;
    
    if(loop==true){
        ask();
        getUseNum();
        randNum();
        
    }else{cout<<"!!YOU WIN, HORRRAAAYYY!! "<<endl;}
};

string ask(){
    string pick = "I'm thinking of a number between 1 and 100 ";
    string pick1 = "what do you think it is?";
    cout << pick,pick1;
    return pick, pick1;
}

int getUseNum (){
    int userNum;
    cin>>userNum;
    
    return userNum;
}

int randNum(){
    srand(time(0));
    int randNum =(rand() % 101);
    
    return randNum;
}

Still not done, I still need to add code that test if the players number is true.
Tell me if there anything i can add to advance it so far.
I also am not good at using the actual functions and return types, so advice on that will be nice.

[jimblumberg]

Since you don't seem to be using C-strings you don't need the depreciated C header <string.h> and if you do need this header you should use the C++ version of this header <cstring>. But since you are using C++ strings you should include the header for that class <string>.

Next look at this snippet:

    return pick, pick1;

You can only return one item from a function using the return statement, if you need to return more think about using reference parameters or return a structure/class.

Look at this snippet:

   if(loop==true){

Are you aware that an if() statement is not a loop construct as indicated by the name of your variable? And when dealing with Boolean variables you really don't need to compare to true, if(loop) would be all you need.

Lastly srand() should only be called once, usually early in main().


Jim

[jago the tiger]

HOLD UP, am I tripping or isn't this sapose to run!?!?

#include <iostream>
#include <string>

using namespace std;

int main(){
    for(int x; x > 3; x++)
    {
        cout << "checking if my brain is working. " <<endl;
    }
}

Its not running.

[jimblumberg]

Perhaps you need to initialize x in your for() loop initialization section?

Jim