[Hydroify]

Another quick question would it be best to use a If statement or a while loop?

[andrewsw]

They are not comparable. If is a single conditional statement, while is a loop structure.

[Hydroify]

I know it is not the cleanest but this is what i got so far. But, it only puts the invalid data once then it goes through upon next line

        private static int Month()
        {
            int month = 0;
            string input = Console.ReadLine();
            bool isSuccess = int.TryParse(input, out month);

            if(isSuccess == false)
            {
                    Console.Write("Invalid value please try again >> ");
                    input = Console.ReadLine();
                   
            } 
            else
            {
                while (month < MIN_MONTH || month > MAX_MONTH)
                {
                    Console.Write("Invalid value. Please enter month again >> ");
                    input = Console.ReadLine();
                    
                }
            }

[Skydiver]

I suggest testing your code instead of having us debug by proxy. Just eyeballing that you've got issues with an infinite loop in one case, or unexpected results in another.

[Hydroify]

I tried it usually skips over the while loop for the MIN_MONTH and MAX_MONTH

[Skydiver]

Try entering 26.

[Hydroify]

it catches it and gives me the invalid data message but when i hit a it stuck in a infinite loop lol.

[Hydroify]

Thanks everyone it works now everything i mean.

[andrewsw]

Good. You could post your final version for anyone interested.

[Hydroify]

        private static int Month()
        {
            int month = 0;
            string input = Console.ReadLine();
       
            // If value is not numaric then it throws this error
            while(!int.TryParse(input, out month))
            {
                    Console.Write("Value is not numaric. Please enter month again >> ");
                    input = Console.ReadLine();
                   
            }

            // If value is lower than 1 or higher than 12 it throws this error
            while (month < MIN_MONTH || month > MAX_MONTH)
            {
                   Console.Write("Invalid value. Please enter month again >> ");
                   month = Convert.ToInt32(Console.ReadLine());
                   
            }
            return month;
        }

This does not work if you happen to type a number to high for instance '26' in first then a letter.

This post has been edited by Hydroify: 19 November 2015 - 01:07 PM

[Skydiver]

LOL! So what happens if the user first enters "26" and then later enters "I Love Hydroify" ?

[Hydroify]

updated code works now

        private static int Month()
        {
            int month = 0;
            string userInput = Console.ReadLine();
            bool isSuccess = false;

            while (!isSuccess)
            {
                if (int.TryParse(userInput, out month))
                    // If value is lower than 1 or higher than 12 it throws this error
                    if(month < MIN_MONTH || month > MAX_MONTH)
                {
                    Console.Write("Invalid value. Please enter month again >> ");
                    userInput = Console.ReadLine(); 
                }
                else
                    isSuccess = true;
                else
                {
                    // If value is not numaric then it throws this error
                    Console.Write("Value is not numaric. Please enter month again >> ");
                    userInput = Console.ReadLine();
                }
            }
            return month;
        }

And Skydiver if '26' is entered it says Invalid value. Please enter month again. and if 'I Love Hydroify' is entered it says Value is not numeric. Please enter month again.