[ratonhnaketon]

hello. i have a html like this :

<tr> 
<td>                
  <input type="checkbox">
</td>
<td>example</td>
<td>new test</td>
</tr> 

i want to click on the "tr" and check the checkbox.
my jquery code to do this is :

$("tr").click(function() {
  var checkbox = $("tr input");
  if(checkbox.is(":checked")) {
    this.prop('checked', 'false');
  }
  else {
    this.prop('checked', 'true');
  }
});

it does not work at all.
i'm newbie to jquery so please help me !

This post has been edited by ratonhnaketon: 29 December 2016 - 05:01 AM

[andrewsw]

Are there errors in your browser's console?

[ratonhnaketon]

andrewsw, on 29 December 2016 - 05:51 AM, said:

Are there errors in your browser's console?

NO there isn't.

[astonecipher]

I think you should check again. If there are not error showing, something is wrong.

[ratonhnaketon]

astonecipher, on 29 December 2016 - 07:55 AM, said:

I think you should check again. If there are not error showing, something is wrong.

there is this Warning :

jQuery.Deferred exception: cells[i].val is not a function TypeError: cells[i].val is not a function
    at HTMLdocument.<anonymous> (http://vahedyar.ir/assets/js/scripts.js:23:17)
    at mightThrow (http://vahedyar.ir/assets/js/jquery.js:3505:29)
    at process (http://vahedyar.ir/assets/js/jquery.js:3573:12) undefined

But it's not related to this part. it's about another part of code.

[astonecipher]

If there is an error found in JS, it stops executing. However, there are some errors in what you posted as well.

[astonecipher]

A little help,

$("tr").click(function() {
    var checkbox = $(this).find('input[type="checkbox"]');

However, that won't work until you get the other Javascript issues worked out.

[ratonhnaketon]

astonecipher, on 29 December 2016 - 12:51 PM, said:

A little help,

$("tr").click(function() {
    var checkbox = $(this).find('input[type="checkbox"]');

However, that won't work until you get the other Javascript issues worked out.

Do "Warnings" Stop js from Executing too ?

[ratonhnaketon]

Now this is my code :

$("tr").click(function() {
  var checkbox = $(this).find('input[type="checkbox"]');
  if(checkbox.is(":checked")) {
    $(this).prop('checked', 'false');
  }
  else {
    $(this).prop('checked', 'true');
  }
});

there isn't any warnings or errors in the console and the code is still not working !

[astonecipher]

Pretty sure that isn't what i put. And I don't think you know what $(this), references.

[ratonhnaketon]

astonecipher, on 29 December 2016 - 01:07 PM, said:

Pretty sure that isn't what i put. And I don't think you know what $(this), references.

You Were Wright ! i updated my code and it works ! but only once and only for checking! not unchecking!

$('body').on("click", "tr", function(event) {

  var target = $(event.target);
  if (target.is('input:checkbox')) return;
  var checkbox = $(this).find("input[type='checkbox']");
  if( checkbox.is(":checked") ){
    checkbox.attr("checked","false");
  } else {
    checkbox.attr("checked","true");
  }

});

any other help ?

[astonecipher]

attr adds an attribute, it won't remove it.

		(function() {
			$("tr").click(function() {
				var checkbox = $(this).find('input[type="checkbox"]');
				if (checkbox.is(":checked")) {
					console.log('unchecked')
					checkbox.prop('checked', true)
				} else {
					console.log('checked')
					checkbox.prop('checked', false)
				} 
			});
		}());

[astonecipher]

Swapped some values that made it fail.