My style wins!

  • (2 Pages)
  • +
  • 1
  • 2

18 Replies - 3131 Views - Last Post: 11 April 2018 - 10:44 AM Rate Topic: -----

#16 xclite   User is offline

  • I wrote you an code
  • member icon


Reputation: 1282
  • View blog
  • Posts: 4,091
  • Joined: 12-May 09

Re: My style wins!

Posted 07 July 2017 - 12:58 PM

View Postjon.kiparsky, on 07 July 2017 - 10:24 AM, said:

What is this with people not having a house style guide and running a linter? Why wouldn't you do this?

Undue influence of veteran employees who are happy with the status quo.
Was This Post Helpful? 0
  • +
  • -

#17 jon.kiparsky   User is offline

  • Beginner
  • member icon


Reputation: 11096
  • View blog
  • Posts: 18,982
  • Joined: 19-March 11

Re: My style wins!

Posted 07 July 2017 - 01:03 PM

Happy? Who said anyone was allowed to be happy?
Was This Post Helpful? 0
  • +
  • -

#18 Skydiver   User is online

  • Code herder
  • member icon

Reputation: 6293
  • View blog
  • Posts: 21,632
  • Joined: 05-May 12

Re: My style wins!

Posted 13 July 2017 - 02:42 PM

OMG!

This time it's not a style change by our serial style changer, but equally "interesting". Here's the diff the occurs multiple times:
-    startTime = startTime + " EDT";
+    startTime = startTime;


Was This Post Helpful? 0
  • +
  • -

#19 Skydiver   User is online

  • Code herder
  • member icon

Reputation: 6293
  • View blog
  • Posts: 21,632
  • Joined: 05-May 12

Re: My style wins!

Posted 11 April 2018 - 10:44 AM

I know this is several months later and I'm happily not embedded in that team anymore. I have to admit to a lot of schadenfreude when I saw messages go across Slack regarding merge conflicts trying to go merge back into the development branch the other developers had also adopted the "license to reformat code that you are not even touching".
Was This Post Helpful? 0
  • +
  • -

  • (2 Pages)
  • +
  • 1
  • 2