8 Replies - 1622 Views - Last Post: 08 December 2018 - 05:03 AM

#1 O'Niel   User is offline

  • D.I.C Regular

Reputation: 15
  • View blog
  • Posts: 464
  • Joined: 13-September 15

Self-made online ticket system

Posted 07 July 2018 - 05:12 PM

Hey!

I have made a ticketing system for a small festival/party in my local area.
All the coding work (checking, datbase, validation, mailing, design,...) is done by myself (ofcourse by using libraries and a payment API).

https://ndvibes.com/...ystem/index.php (Demo version)

Feedback on it being user-friendly and nicely designed is appreciated.
It's in dutch, but you should be able to navigate it fine being english.

Small dictionary:
  • Koop nu jouw ticket = Buy your ticket now
  • Ja = Yes
  • Nee = No
  • Volgende = Next
  • Firstname = Voornaam
  • Lastname = Achternaam
  • Betalen = Pay
  • Afdrukken = To print out


I had some problems formatting the HTML-ticket in mails, some tips on improving that
would be appreciated a lot!

Code:
https://github.com/U...TicketingSystem
I'd also like some feedback on the quality of the code. :)/>/>/>/>

Thanks!

This post has been edited by O'Niel: 07 July 2018 - 05:15 PM


Is This A Good Question/Topic? 1
  • +

Replies To: Self-made online ticket system

#2 modi123_1   User is online

  • Suitor #2
  • member icon



Reputation: 15262
  • View blog
  • Posts: 61,178
  • Joined: 12-June 08

Re: Self-made online ticket system

Posted 07 July 2018 - 05:33 PM

Did you have multiple people test it?
Was This Post Helpful? 0
  • +
  • -

#3 O'Niel   User is offline

  • D.I.C Regular

Reputation: 15
  • View blog
  • Posts: 464
  • Joined: 13-September 15

Re: Self-made online ticket system

Posted 07 July 2018 - 05:43 PM

Not yet, I first wanted to make sure the design and principle/way of work was 'approved' here.
So that I don't have to ask a group of people multiple times to test it.
Was This Post Helpful? 0
  • +
  • -

#4 modi123_1   User is online

  • Suitor #2
  • member icon



Reputation: 15262
  • View blog
  • Posts: 61,178
  • Joined: 12-June 08

Re: Self-made online ticket system

Posted 07 July 2018 - 05:55 PM

I would think you would want people putting it through it's paces on the ticket selling and validation ends waaaaaaaay before any actual use.

As it is - I would figure the 'privacy checkbox' would have a link to.. you know.. the privacy policy. ;) I would also have it linked at the bottom of every page.

I would also have a 'contact for support' email at the bottom of every page.

IF I am filling in dummy data and click the buy a ticket I would hope it would tell me what I miss-entered wrongly.
Was This Post Helpful? 1
  • +
  • -

#5 Skydiver   User is online

  • Code herder
  • member icon

Reputation: 7054
  • View blog
  • Posts: 23,983
  • Joined: 05-May 12

Re: Self-made online ticket system

Posted 08 July 2018 - 06:19 AM

Moved to Site Check...
Was This Post Helpful? 1
  • +
  • -

#6 O'Niel   User is offline

  • D.I.C Regular

Reputation: 15
  • View blog
  • Posts: 464
  • Joined: 13-September 15

Re: Self-made online ticket system

Posted 09 July 2018 - 05:00 AM

View Postmodi123_1, on 07 July 2018 - 05:55 PM, said:

I would think you would want people putting it through it's paces on the ticket selling and validation ends waaaaaaaay before any actual use.

As it is - I would figure the 'privacy checkbox' would have a link to.. you know.. the privacy policy. ;)/> I would also have it linked at the bottom of every page.

I would also have a 'contact for support' email at the bottom of every page.

IF I am filling in dummy data and click the buy a ticket I would hope it would tell me what I miss-entered wrongly.


Thanks for the tips! They're all noted!
Was This Post Helpful? 0
  • +
  • -

#7 benanamen   User is offline

  • D.I.C Head

Reputation: 36
  • View blog
  • Posts: 242
  • Joined: 28-March 15

Re: Self-made online ticket system

Posted 07 December 2018 - 06:00 PM

Probably no point in commenting since you haven't updated the code in almost half a year but what the heck.

There are so many issues with your code I am not even going to attempt to get into it all so I will mostly stick to the index.php

The code depends on the name of a button being submitted in order for the code to work. This can completely fail in certain cases. You need to check the REQUEST METHOD instead.

You fail to kill the script after header redirects.

You create variables for nothing. There are at least 3 different ones just for firstname alone.

There is no separation of concerns. The HTML should be moved out of the code to a template file. You repeat the HTML headers all over the place instead of including a single file.

You modify submitted data with HTML output functions before inserting into the DB. You again use an output function on DB delete parameters. htmlspecialchars is for HTML data OUTPUT, not input.
Was This Post Helpful? 1
  • +
  • -

#8 O'Niel   User is offline

  • D.I.C Regular

Reputation: 15
  • View blog
  • Posts: 464
  • Joined: 13-September 15

Re: Self-made online ticket system

Posted 08 December 2018 - 03:59 AM

Thanks a lot!
The evenement will need the ticketing system again in September
after it was succesful previous year.

I'll rewrite most of the code in June and take your suggestions
in mind when doing it. Very helpful.
Was This Post Helpful? 0
  • +
  • -

#9 ndc85430   User is offline

  • I think you'll find it's "Dr"
  • member icon

Reputation: 981
  • View blog
  • Posts: 3,861
  • Joined: 13-June 14

Re: Self-made online ticket system

Posted 08 December 2018 - 05:03 AM

Some more thoughts: learn how to write tests for your software. First, they help you to continue to have working software when you change anything. If tests start failing when you change something, you know you've broken it. Second, because they can be run automatically as part of your build process, they facilitate getting software into production early and often. The basic steps are make a small change and make sure all the tests pass (both the existing ones and the ones you've added for this change), commit, push and have a system that builds the software (running all the tests) and deploys it if successful. Look up continuous integration/deployment (CI/CD) for tools, etc. that help with this. Arguably, you don't need to run all the tests locally each time you make a change, since the CI server will do it. That's how we work - we test drive our software, so write tests before adding new functionality and make sure they pass before committing and pushing. The entire suite of tests will run on the CI server, so if something has broken, the deployment won't happen.
Was This Post Helpful? 1
  • +
  • -

Page 1 of 1