[lolwtfdemon]

Hey, I am looking to get a junior dev job hopefully in the near future and was curious if anyone would be open to giving me feedback on my Github. It's a little messy and unorganized right now so I have to clean that up. But if anyone would be interested in giving me feedback, ideas of what to include, or just downright roast me that would be appreciated! />

GITHUBBBBBBBBBBBB

[modi123_1]

Not a whole lot there.
Nothing is explained.
No project information or about.
The code is a 'meh'.

[lolwtfdemon]

A meh is better than absolute garbage though. I didn't really think to add comments to explain what things do though..... I'll do that. Thank you!

[jon.kiparsky]

Start with a README, and then work your way down from there.

[lolwtfdemon]

jon.kiparsky, on 24 October 2019 - 09:09 PM, said:

Start with a README, and then work your way down from there.

Do you mean put a readme at the beginning of the code and then add comments down?

or is this a roast?

[modi123_1]

No, a readme for your repo.

[lolwtfdemon]

Roger that.

[lolwtfdemon]

modi123_1, what do you think of the morse code translator?

[baavgai]

lolwtfdemon, on 25 October 2019 - 12:31 AM, said:

what do you think of the morse code translator?

I didn't see a "morse code translator." I'm assuming it's in one of the undescriptively named repos? Begin with a read me.

Oh, wait, found it: https://github.com/t...morse_decode.py

This tells you what to do next: your read me should describe each of the scripts and what they show off.

As to the code... include in that read me how to use it. Also, wrangle all that global space code into a main. Provide example usage and maybe example data.

The giant if/then fills me with fear. Can it be a dict? The values 'boop' and 'hold' are practically magic. Rather than use strings throughout the code, prefer a couple constants.

The craigs_email looked like fun. I did a quick refactor of it:

Spoiler

#!/usr/bin/python3

import requests
from bs4 import BeautifulSoup as BS
import os
import smtplib
import pandas as pd
import re
from email.mime.text import MIMEText


def find_cars_data(search, max_price, make, max_results):
    headers = {'user-agent': 'Mozilla/5.0 (iPhone; CPU iPhone OS 9_2 like Mac OS X)'}
    search_params = {'sort': 'rel',
                     'min_price': '50',
                     'max_price': max_price,
                     'query': make,
                     'auto_transmission': '1',
                     'srchType': 'T'}

    r = requests.get(search, params=search_params, headers=headers)
    s = BS(r.content, 'html.parser')
    # c = s.prettify
    for i, a in enumerate(s.find_all('p', {'class': 'result-info'})):
        price = a.find('span', {'class': 'result-price'}).text
        title = a.find('a', {'class': 'result-title'}).text
        link = a.find('a', attrs={'href': re.compile("^https://")})
        yield (price, title, link.get('href'))

        if not i < max_results - 1:
            break


def data_to_pandas(data_gen):
    df = {'Car': [], 'Price': [], 'Link': []}
    for (price, title, link) in data_gen:
        df['Car'].append(title)
        df['Price'].append(price)
        df['Link'].append(link)
    pd.set_option('display.max_colwidth', -1)
    cars = pd.DataFrame(df)
    return(cars.to_html())


def send_gmail(gmail_user, gmail_password, message):
    try:
        server = smtplib.SMTP_SSL('smtp.gmail.com', 465)
        server.ehlo()
        server.login(gmail_user, gmail_password)
        # see below
        server.sendmail(gmail_user, gmail_user, msg=message)
    except e: # include the error, consider a linter
        print(e, 'Whoops....')
    # if you fail out to the except, you shouldn't be trying this here
    # server.sendmail(gmail_user, gmail_user, msg=message)



def main():
    url = 'https://annarbor.craigslist.org/'
    gmail_user, gmail_password = '[email protected]', 'xxxxxxxxxxxxxxx'
    max_price, make, max_results = '20000', 'Volkswagen', 20

    html = data_to_pandas(find_cars_data(url + 'search/sss', max_price, make, max_results))
    msg = MIMEText(html, 'html')

    print(msg.as_string())
    # send_gmail(gmail_user, gmail_password, msg.as_string())


main()

Good luck.

[astonecipher]

Multiple repo's rather than cramming them into as few as possible. A project is a repo in your case. Add somethings that make them more showy to highlight things. Everything is incredibly simple with no complexity at all. Do something that really interests you and add to it incrementally. Include unit testing and multiple branches that show you know other facets of development. Coding for a company is more than just the code itself, using a VCS is part of that, so utilize it more than just for a bulk upload bin.

[lolwtfdemon]

I really appreciate that feed back! Yeah I was messing around when I was looking to get a mk4 Jetta lol. I was thinking about going back to redo that one and clean it up. I like what you did with it.

Yes, I have a new version of the morse code program that works better and using a dict instead of that god awful if statement. What do you mean prefer a couple constants?

baavgai, on 25 October 2019 - 02:35 AM, said:

lolwtfdemon, on 25 October 2019 - 12:31 AM, said:

what do you think of the morse code translator?

I didn't see a "morse code translator." I'm assuming it's in one of the undescriptively named repos? Begin with a read me.

Oh, wait, found it: https://github.com/t...morse_decode.py

This tells you what to do next: your read me should describe each of the scripts and what they show off.

As to the code... include in that read me how to use it. Also, wrangle all that global space code into a main. Provide example usage and maybe example data.

The giant if/then fills me with fear. Can it be a dict? The values 'boop' and 'hold' are practically magic. Rather than use strings throughout the code, prefer a couple constants.

The craigs_email looked like fun. I did a quick refactor of it:

Spoiler

#!/usr/bin/python3

import requests
from bs4 import BeautifulSoup as BS
import os
import smtplib
import pandas as pd
import re
from email.mime.text import MIMEText


def find_cars_data(search, max_price, make, max_results):
    headers = {'user-agent': 'Mozilla/5.0 (iPhone; CPU iPhone OS 9_2 like Mac OS X)'}
    search_params = {'sort': 'rel',
                     'min_price': '50',
                     'max_price': max_price,
                     'query': make,
                     'auto_transmission': '1',
                     'srchType': 'T'}

    r = requests.get(search, params=search_params, headers=headers)
    s = BS(r.content, 'html.parser')
    # c = s.prettify
    for i, a in enumerate(s.find_all('p', {'class': 'result-info'})):
        price = a.find('span', {'class': 'result-price'}).text
        title = a.find('a', {'class': 'result-title'}).text
        link = a.find('a', attrs={'href': re.compile("^https://")})
        yield (price, title, link.get('href'))

        if not i < max_results - 1:
            break


def data_to_pandas(data_gen):
    df = {'Car': [], 'Price': [], 'Link': []}
    for (price, title, link) in data_gen:
        df['Car'].append(title)
        df['Price'].append(price)
        df['Link'].append(link)
    pd.set_option('display.max_colwidth', -1)
    cars = pd.DataFrame(df)
    return(cars.to_html())


def send_gmail(gmail_user, gmail_password, message):
    try:
        server = smtplib.SMTP_SSL('smtp.gmail.com', 465)
        server.ehlo()
        server.login(gmail_user, gmail_password)
        # see below
        server.sendmail(gmail_user, gmail_user, msg=message)
    except e: # include the error, consider a linter
        print(e, 'Whoops....')
    # if you fail out to the except, you shouldn't be trying this here
    # server.sendmail(gmail_user, gmail_user, msg=message)



def main():
    url = 'https://annarbor.craigslist.org/'
    gmail_user, gmail_password = '[email protected]', 'xxxxxxxxxxxxxxx'
    max_price, make, max_results = '20000', 'Volkswagen', 20

    html = data_to_pandas(find_cars_data(url + 'search/sss', max_price, make, max_results))
    msg = MIMEText(html, 'html')

    print(msg.as_string())
    # send_gmail(gmail_user, gmail_password, msg.as_string())


main()

Good luck.

I would agree with you that everything in there is pretty simple (except for maybe the morse code one...). But sadly I only really have my imagination to go off of and google currently. Do you have any ideas for cool complex problems I could take a swing at?

astonecipher, on 25 October 2019 - 07:45 AM, said:

Multiple repo's rather than cramming them into as few as possible. A project is a repo in your case. Add somethings that make them more showy to highlight things. Everything is incredibly simple with no complexity at all. Do something that really interests you and add to it incrementally. Include unit testing and multiple branches that show you know other facets of development. Coding for a company is more than just the code itself, using a VCS is part of that, so utilize it more than just for a bulk upload bin.

[astonecipher]

It comes done to personal interests. You could do a POS system for a restaurant or grocery store; Martyr has an idea book of projects if you really get stuck, but find what you have an interest in and start a project on it.


I wrote a medication reminder once for a friend that just reminded the family when medication needed to be doled out, what it was, the dosage, all configurable based on what the doctor said was need.

[lolwtfdemon]

That's a cool idea. I'll check out that book tomorrow and see if I can pick a few and work on those. Like I said I really appreciate the feedback and the tips! I don't have any friends with an interest in programming in general so it's nice to get feed back.

I made a little POS system in Java for a class so maybe I'll post that in there as well.

astonecipher, on 25 October 2019 - 06:49 PM, said:

It comes done to personal interests. You could do a POS system for a restaurant or grocery store; Martyr has an idea book of projects if you really get stuck, but find what you have an interest in and start a project on it.


I wrote a medication reminder once for a friend that just reminded the family when medication needed to be doled out, what it was, the dosage, all configurable based on what the doctor said was need.

[baavgai]

lolwtfdemon, on 25 October 2019 - 09:34 PM, said:

What do you mean prefer a couple constants?

Numbers and strings in code are sometimes called magic. This has a few issues. One is simply "why the hell did they use X here," Hence the magic. However, just as importantly, is the ability to fat finger things.

If you use 'fizz' and 'buzz' in your code, there's a non zero chance that, at some point, you'll type 'fiz' or 'buz'. Since it's a string, your compiler don't care and finding that bug will cause hair loss. Instead, if you define FIZZ, BUZZ = 'fizz', 'buzz' and reference those constants consistently, a typo will be caught much earlier. Further, in the future, if 'fizz' becomes 'fiz' you need only change the value of the constant and leave the rest of your code alone.

Constants are basically the shortest expression of DRY.

[ndc85430]

Write some automated tests (e.g. unit tests) . Python comes with its own test framework, unittest and there are also third party ones like pytest.